[PATCH v1 1/1] pata_rdc: Use registered definition for the RDC vendor

[PATCH v1 1/1] pata_rdc: Use registered definition for the RDC vendor

[Andy Shevchenko]

Convert to PCI_VDEVICE() and use registered definition for RDC vendor
from pci_ids.h.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/ata/pata_rdc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/ata/pata_rdc.c b/drivers/ata/pata_rdc.c
index 09792aac7f9d..19cbb5c94b42 100644
--- a/drivers/ata/pata_rdc.c
+++ b/drivers/ata/pata_rdc.c
@@ -359,8 +359,8 @@ static void rdc_remove_one(struct pci_dev *pdev)
 }
 
 static const struct pci_device_id rdc_pci_tbl[] = {
-	{ PCI_DEVICE(0x17F3, 0x1011), },
-	{ PCI_DEVICE(0x17F3, 0x1012), },
+	{ PCI_VDEVICE(RDC, 0x1011) },
+	{ PCI_VDEVICE(RDC, 0x1012) },
 	{ }	/* terminate list */
 };
 
-- 
2.47.2

Re: [PATCH v1 1/1] pata_rdc: Use registered definition for the RDC vendor

[Damien Le Moal]

On 7/11/25 8:36 PM, Andy Shevchenko wrote:
> Convert to PCI_VDEVICE() and use registered definition for RDC vendor
> from pci_ids.h.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Commit title needs "ata: " prefix. Niklas, can you add it when applying ?

Reviewed-by: Damien Le Moal <dlemoal@wdc.com>


-- 
Damien Le Moal
Western Digital Research

Re: [PATCH v1 1/1] pata_rdc: Use registered definition for the RDC vendor

[Andy Shevchenko]

On Mon, Jul 14, 2025 at 09:32:09AM +0900, Damien Le Moal wrote:
> On 7/11/25 8:36 PM, Andy Shevchenko wrote:
> > Convert to PCI_VDEVICE() and use registered definition for RDC vendor
> > from pci_ids.h.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> Commit title needs "ata: " prefix. Niklas, can you add it when applying ?

I took the output of

$ git log --oneline --no-merges -- drivers/ata/pata_rdc.c

and tried to deduct what will be the driver specific prefix, there are no
ata: pata_rdc: prefixed changes, so it appears that I made wrong assumption.

> Reviewed-by: Damien Le Moal <dlemoal@wdc.com>

Thanks!

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 1/1] pata_rdc: Use registered definition for the RDC vendor

[Damien Le Moal]

On 7/14/25 4:12 PM, Andy Shevchenko wrote:
> On Mon, Jul 14, 2025 at 09:32:09AM +0900, Damien Le Moal wrote:
>> On 7/11/25 8:36 PM, Andy Shevchenko wrote:
>>> Convert to PCI_VDEVICE() and use registered definition for RDC vendor
>>> from pci_ids.h.
>>>
>>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>>
>> Commit title needs "ata: " prefix. Niklas, can you add it when applying ?
> 
> I took the output of
> 
> $ git log --oneline --no-merges -- drivers/ata/pata_rdc.c
> 
> and tried to deduct what will be the driver specific prefix, there are no
> ata: pata_rdc: prefixed changes, so it appears that I made wrong assumption.

It is probably because that driver has not been touched in a long time :)
These days, we try to be consistent with the patch titles and have the "ata: "
prefix for all of them to make git log searches easier.


-- 
Damien Le Moal
Western Digital Research

Re: [PATCH v1 1/1] pata_rdc: Use registered definition for the RDC vendor

[Niklas Cassel]

On Fri, 11 Jul 2025 14:36:50 +0300, Andy Shevchenko wrote:
> Convert to PCI_VDEVICE() and use registered definition for RDC vendor
> from pci_ids.h.
> 
> 

Applied to libata/linux.git (for-6.17), thanks!

[1/1] pata_rdc: Use registered definition for the RDC vendor
      https://git.kernel.org/libata/linux/c/148fbaf5

Kind regards,
Niklas

Re: [PATCH v1 1/1] pata_rdc: Use registered definition for the RDC vendor

[Niklas Cassel]

On Mon, Jul 14, 2025 at 09:32:09AM +0900, Damien Le Moal wrote:
> On 7/11/25 8:36 PM, Andy Shevchenko wrote:
> > Convert to PCI_VDEVICE() and use registered definition for RDC vendor
> > from pci_ids.h.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> Commit title needs "ata: " prefix. Niklas, can you add it when applying ?

Yes :)


Kind regards,
Niklas