From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F876182D8; Thu, 1 Aug 2024 18:11:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.154.21.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722535870; cv=none; b=m4OFJ+rQYOareWWs6gm9Srm83mS8/wtS5eZtIhhxnCPDWN/MRFQPLpJ7KzzMcmb8dGMXtWy2mvFtZ7Ics/AbG4XfRLK/U9ev6/rPX0olXlbSlYsPlzI2sq8rlic2A2KQDUE9QxbEEmjuI2FLVsmq2UFjAIrg83551DTJIzWgiMM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722535870; c=relaxed/simple; bh=71kV20FqY4Ai8IF+fb62AaJM3opVatT4U0WLYn/1oPQ=; h=Subject:To:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=KmzsP2joqdEcATaVZbAEw740u5l3O5dDtQTzTuYVLRj2TkvkNOEKrdP2+9YtS+wNkI5vhhNtCL2f3+Suku85mmIoqMMtzN/WvIc4nluQPQdYfis+YznwDXLGtnpL1ks38NqK2MjXODaD8GnlbgoeLTCh8LnUY9waKn4G0gMeFJ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru; spf=pass smtp.mailfrom=omp.ru; arc=none smtp.client-ip=90.154.21.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=omp.ru Received: from [192.168.1.105] (31.173.80.208) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1258.12; Thu, 1 Aug 2024 21:10:52 +0300 Subject: Re: [PATCH] ata: libata: Remove ata_noop_qc_prep() To: Damien Le Moal , , Niklas Cassel , , "Martin K . Petersen" , John Garry References: <20240801090151.1249985-1-dlemoal@kernel.org> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: <7186ee2c-e1de-1b59-41b2-e2ca45e21b0e@omp.ru> Date: Thu, 1 Aug 2024 21:10:51 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 Precedence: bulk X-Mailing-List: linux-ide@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20240801090151.1249985-1-dlemoal@kernel.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 6.1.0, Database issued on: 08/01/2024 17:54:18 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 59 X-KSE-AntiSpam-Info: Lua profiles 186842 [Aug 01 2024] X-KSE-AntiSpam-Info: Version: 6.1.0.4 X-KSE-AntiSpam-Info: Envelope from: s.shtylyov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 24 0.3.24 186c4d603b899ccfd4883d230c53f273b80e467f X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: {relay has no DNS name} X-KSE-AntiSpam-Info: {SMTP from is not routable} X-KSE-AntiSpam-Info: {Found in DNSBL: 31.173.80.208 in (user) b.barracudacentral.org} X-KSE-AntiSpam-Info: {Found in DNSBL: 31.173.80.208 in (user) dbl.spamhaus.org} X-KSE-AntiSpam-Info: omp.ru:7.1.1;127.0.0.199:7.1.2;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1 X-KSE-AntiSpam-Info: ApMailHostAddress: 31.173.80.208 X-KSE-AntiSpam-Info: {DNS response errors} X-KSE-AntiSpam-Info: Rate: 59 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 08/01/2024 17:57:00 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 8/1/2024 4:48:00 PM X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit Hello! Not sure why you keep leaving me out of CC on the patches that touch the PATA drivers... :-/ On 8/1/24 12:01 PM, Damien Le Moal wrote: > The function ata_noop_qc_prep(), as its name implies, does nothing and > simply returns AC_ERR_OK. For drivers that do not need any special > preparations of queued commands, we can avoid having to define struct > ata_port qc_prep operation by simply testing if that operation is > defined or not in ata_qc_issue(). Make this change and remove > ata_noop_qc_prep(). > > Signed-off-by: Damien Le Moal Reviewed-by: Sergey Shtylyov [...] MBR, Sergey