From: Hannes Reinecke <hare@suse.de>
To: Adam Manzanares <adam.manzanares@hgst.com>,
axboe@kernel.dk, tj@kernel.org, dan.j.williams@intel.com,
martin.petersen@oracle.com, mchristi@redhat.com,
toshi.kani@hpe.com, ming.lei@canonical.com,
sathya.prakash@broadcom.com, chaitra.basappa@broadcom.com,
suganath-prabu.subramani@broadcom.com
Cc: linux-block@vger.kernel.org, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org, MPT-FusionLinux.pdl@broadcom.com,
linux-scsi@vger.kernel.org,
Adam Manzanares <adam.manzanares@wdc.com>
Subject: Re: [PATCH v4 2/4] fusion: remove iopriority handling
Date: Fri, 14 Oct 2016 07:55:09 +0200 [thread overview]
Message-ID: <749dbbbb-fe5a-2e75-a672-3d6ea2bdbff8@suse.de> (raw)
In-Reply-To: <1476388433-2539-3-git-send-email-adam.manzanares@hgst.com>
On 10/13/2016 09:53 PM, Adam Manzanares wrote:
> The request priority is now by default coming from the ioc. It was not
> clear what this code was trying to do based upon the iopriority class or
> data. The driver should check that a device supports priorities and use
> them according to the specificiations of ioprio.
>
> Signed-off-by: Adam Manzanares <adam.manzanares@wdc.com>
> ---
> drivers/message/fusion/mptscsih.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/message/fusion/mptscsih.c b/drivers/message/fusion/mptscsih.c
> index 6c9fc11..4740bb6 100644
> --- a/drivers/message/fusion/mptscsih.c
> +++ b/drivers/message/fusion/mptscsih.c
> @@ -1369,11 +1369,6 @@ mptscsih_qcmd(struct scsi_cmnd *SCpnt)
> if ((vdevice->vtarget->tflags & MPT_TARGET_FLAGS_Q_YES)
> && (SCpnt->device->tagged_supported)) {
> scsictl = scsidir | MPI_SCSIIO_CONTROL_SIMPLEQ;
> - if (SCpnt->request && SCpnt->request->ioprio) {
> - if (((SCpnt->request->ioprio & 0x7) == 1) ||
> - !(SCpnt->request->ioprio & 0x7))
> - scsictl |= MPI_SCSIIO_CONTROL_HEADOFQ;
> - }
> } else
> scsictl = scsidir | MPI_SCSIIO_CONTROL_UNTAGGED;
>
>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2016-10-14 5:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 19:53 [PATCH v4 0/4] Enabling ATA Command Priorities Adam Manzanares
2016-10-13 19:53 ` [PATCH v4 1/4] block: Add iocontext priority to request Adam Manzanares
2016-10-13 20:06 ` Dan Williams
2016-10-13 20:09 ` Jens Axboe
2016-10-13 20:19 ` Dan Williams
2016-10-13 20:24 ` Jens Axboe
2016-10-13 20:59 ` Dan Williams
2016-10-13 21:07 ` Jens Axboe
2016-10-13 22:02 ` Adam Manzananares
2016-10-14 5:54 ` Hannes Reinecke
2016-10-14 18:35 ` Adam Manzananares
2016-10-15 8:43 ` Hannes Reinecke
2016-10-13 19:53 ` [PATCH v4 2/4] fusion: remove iopriority handling Adam Manzanares
2016-10-13 21:05 ` Sathya Prakash Veerichetty
2016-10-13 22:12 ` Adam Manzanares
2016-10-14 5:55 ` Hannes Reinecke [this message]
2016-10-13 19:53 ` [PATCH v4 3/4] ata: Enabling ATA Command Priorities Adam Manzanares
2016-10-13 19:53 ` [PATCH v4 4/4] ata: ATA Command Priority Disabled By Default Adam Manzanares
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=749dbbbb-fe5a-2e75-a672-3d6ea2bdbff8@suse.de \
--to=hare@suse.de \
--cc=MPT-FusionLinux.pdl@broadcom.com \
--cc=adam.manzanares@hgst.com \
--cc=adam.manzanares@wdc.com \
--cc=axboe@kernel.dk \
--cc=chaitra.basappa@broadcom.com \
--cc=dan.j.williams@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mchristi@redhat.com \
--cc=ming.lei@canonical.com \
--cc=sathya.prakash@broadcom.com \
--cc=suganath-prabu.subramani@broadcom.com \
--cc=tj@kernel.org \
--cc=toshi.kani@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox