Re: [PATCH v2 3/3] m68k/atari: change Falcon IDE platform device to id 0

[Michael Schmitz <schmitzmic@gmail.com>]

Hi Finn,

Am 19.08.2023 um 12:07 schrieb Finn Thain:
>
> On Sat, 19 Aug 2023, Michael Schmitz wrote:
>
>>>
>>> Iff this patch is accepted, it must go in before [PATCH v2 2/3], else
>>> the latter would cause a regression. And backporting to stable must
>>> take that into account, too.
>>
>> I don't see it as a regression - the driver still works OK, it's only
>> the byte swap option that's broken on Atari, and that's newly
>> introduced.
>>
>> But this patch changes the user space exposed platform device name, as
>> you point out elsewhere. That's reason enough to drop it.
>>
>
> Such a script would be broken on q40 already.

Not necessarily - what I thought of was something like the Debian 
installer.

I don't know for a fact that it relies on the device naming as it is at 
present (or even that it supports Q40), but I'd rather not needlessly 
change something that might break user space code.

> When a fix has a dependency on a separate patch you can backport both by
> specifying a cherry-picking sequence. We may need Geert to add those
> commit hashes though. This is discussed in
> Documentation/process/stable-kernel-rules.rst

If Geert prefers to change the Atari IDE platform device ID, he's always 
free to do that :-)

The current patch will work either way.

Cheers,

	Michael