From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D447C433F5 for ; Wed, 2 Feb 2022 22:00:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347747AbiBBWAj (ORCPT ); Wed, 2 Feb 2022 17:00:39 -0500 Received: from esa6.hgst.iphmx.com ([216.71.154.45]:29126 "EHLO esa6.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346589AbiBBWAh (ORCPT ); Wed, 2 Feb 2022 17:00:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1643839237; x=1675375237; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=3Ho4phF9JGcLvbyerVK0BW2rioDCJEu5n4cMKnvRebk=; b=dMWKzbHVm9qpM3lvUn3J6z03SR6MwGfEnKGqQTOAdcnT4pUUcbe4ALMn w8oZBWDj19jWxNpyk5urwquSrRHYhuyaqt00AOAqxUYeG6OA2SEhiqjfQ qyQobaTIyVYPe2xvXgLDaN7lTg8/7+hhr9Q8D22/ZEK0HPuEgCRVdaMLc oOWgmKpj8h+kJKPtexfyR57xJlPibDCmFv/9aDko8oYrOMZDg6+6sYVqp AY8Xd2SA+0xcaoE03wZIZHyqlkvsxe1ZhRkN6uEADnCQKfiFBFp0InSUM izP0wLMaImo3eROLXqqhzT3v0oeq3ysUZTBjuMdMzIsJhZopEOQmQ56S4 A==; X-IronPort-AV: E=Sophos;i="5.88,337,1635177600"; d="scan'208";a="193000336" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 03 Feb 2022 06:00:36 +0800 IronPort-SDR: Wpo6Y9+d4ZsK1LTK3t7vRonBYDSpznvoGvJ5Vg/vGYWug8OLL/OurZ1ha+q4pdxT6eAii6Iml9 inBL4EcOU8fCA4NsAN+h+ueQtqNbS7KNjxwu8gR4fBRlT0zD2WNIkrMHJSqDeeo0FxFIpZnmyE MmWDdQXmbQZb2K3hoEK2RQfq6WOliCewk+pOCzV9F5QFcRcwP0ZF3t+mbC0u91VBisDu/UA1Df A3e1bypVl43aAlGr53hAFftGraE9kGWve8LAjvTnHbC+Q8s/q3uxtuc4vWtTQliVwfL0D96ycy L1E59zc1bi9G10hTBQsCcpvZ Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2022 13:32:31 -0800 IronPort-SDR: 1/gRh4q3fDNfqrpEK1R+H02hNMqYSul5puE00Q6/F/7WzfNrcYLOZhy8VgommBg/bxG9FLk8Gl BbbGKFAjAQSwVTD+xjo/lE2gcp9V3UYA7vSZwOph+4ADqs6kmFTi8OXXliVyHskbkrH/01lTAy XFdw8PN0ZwYFLnJ5tMHmiOil/oLfZTuQDbL2dnmmkxkEf1DncGzsM5qunvVDejB8ptnhUEd4gC IpZ6iCGBlbxkrmI7MlCIEsiAvjK9ythMFSGtfjUC9MsMx8R+lR9K2H48A3AOxUdram5CzYmylK iqY= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2022 14:00:35 -0800 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Jpwhy4VMjz1SVnx for ; Wed, 2 Feb 2022 14:00:34 -0800 (PST) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1643839234; x=1646431235; bh=3Ho4phF9JGcLvbyerVK0BW2rioDCJEu5n4c MKnvRebk=; b=en+uZ19LksxPnmhK+BRKim7m3haw7o/OUIN9nGGuOj3iT8O01tD IT2PdcvXwDr8ktf5+GvQQk7kregitYJJsctQKzviVXB7QsemFozK/A0IMq+013SU 3mOPIsw1sv4gUsIA51ZXqIIVkggN+aou8PiAaX88i5YVZyHYHLl7v236gA/h62CI Oycekfy57X1iEWOTK4nUv5DoCqBtnL/UVnMa5I7c1a3AlSCKe6fubytUxiqgVmwm 2aju+f0nKxJAb0k06KrFNNgNNUU8Fo4zqcrpThktqC5hNvJGDTKVYAqTHtK4+UAN FaRr4erWSXDBy8ZCgo6n/dN4bzSgWY6MpCw== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 9KNJjwUPLD4e for ; Wed, 2 Feb 2022 14:00:34 -0800 (PST) Received: from [10.225.54.48] (unknown [10.225.54.48]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Jpwhx5bfjz1Rwrw; Wed, 2 Feb 2022 14:00:33 -0800 (PST) Message-ID: <77e0c3b6-5a06-87f4-3718-bacdd8f01728@opensource.wdc.com> Date: Thu, 3 Feb 2022 07:00:32 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH] libata: Don't issue ATA_LOG_DIRECTORY to SATADOM-ML 3ME Content-Language: en-US To: Anton Lundin Cc: linux-ide@vger.kernel.org References: <20220202100536.1909665-1-glance@acc.umu.se> <20220202122520.GE723116@montezuma.acc.umu.se> <20220202130921.GF723116@montezuma.acc.umu.se> <20220202135458.GH723116@montezuma.acc.umu.se> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20220202135458.GH723116@montezuma.acc.umu.se> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On 2022/02/02 22:54, Anton Lundin wrote: > On 02 February, 2022 - Anton Lundin wrote: > >> On 02 February, 2022 - Damien Le Moal wrote: >> >>> On 2022/02/02 21:25, Anton Lundin wrote: >>>> On 02 February, 2022 - Damien Le Moal wrote: >>>> >>>>> On 2/2/22 19:05, Anton Lundin wrote: >>>>>> Back in 06f6c4c6c3e8 ("ata: libata: add missing ata_identify_page_supported() calls") >>>>>> a read of ATA_LOG_DIRECTORY page was added. This caused the >>>>>> SATADOM-ML 3ME to lock up. >>>>>> >>>>>> In 636f6e2af4fb ("libata: add horkage for missing Identify Device log") >>>>>> a flag was added to cache if a device supports this or not. >>>>>> >>>>>> This adds a blacklist entry which flags that these devices doesn't >>>>>> support that call and shouldn't be issued that call. >>>>>> >>>>>> Cc: stable@vger.kernel.org # v5.10+ >>>>>> Signed-off-by: Anton Lundin >>>>>> Depends-on: 636f6e2af4fb ("libata: add horkage for missing Identify Device log") >>>>> >>>>> I do not think so. See below. >>>>> >>>>>> --- >>>>>> drivers/ata/libata-core.c | 7 +++++++ >>>>>> 1 file changed, 7 insertions(+) >>>>>> >>>>>> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c >>>>>> index 87d36b29ca5f..e024af9f33d0 100644 >>>>>> --- a/drivers/ata/libata-core.c >>>>>> +++ b/drivers/ata/libata-core.c >>>>>> @@ -4070,6 +4070,13 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = { >>>>>> { "WDC WD3000JD-*", NULL, ATA_HORKAGE_WD_BROKEN_LPM }, >>>>>> { "WDC WD3200JD-*", NULL, ATA_HORKAGE_WD_BROKEN_LPM }, >>>>>> >>>>>> + /* >>>>>> + * This sata dom goes on a walkabout when it sees the >>>>>> + * ATA_LOG_DIRECTORY read request so ensure we don't issue such a >>>>>> + * request to these devices. >>>>>> + */ >>>>>> + { "SATADOM-ML 3ME", NULL, ATA_HORKAGE_NO_ID_DEV_LOG }, >>>>> >>>>> This flag only disables trying to access the identify device log page, >>>>> it does *not* avoid access to the log directory log page in general. The >>>>> log directory will still be consulted for other log pages beside the >>>>> identify device log page, from any function that calls >>>>> ata_log_supported() (e.g. ata_dev_config_ncq_send_recv() and >>>>> ata_dev_config_ncq_non_data()) >>>> >>>> Non of those code paths are called for this device, probably due to some >>>> other flag disqualifying them. >>>> >>>>> So it will be a lot more solid to define a ATA_HORKAGE_NO_LOG_DIR flag >>>>> and test for it in ata_log_supported(), completely preventing any access >>>>> to the log directory page for this drive type. >>>> >>>> That was my first thought but then I found ATA_HORKAGE_NO_ID_DEV_LOG >>>> which was in the calling path that actually triggered this issue. >>>> >>>> But, yes, I totally agree that's a more solid solution preventing this >>>> kind of issue to crop up again. >>>> >>>>>> + >>>>>> /* End Marker */ >>>>>> { } >>>>>> }; >>>>> >>>>> Note: if you need this fix sent to linux-stable, add "Cc: stable@..." >>>>> and a Fixes tag. >>>> >>>> I'd think it's fitting to send it to linux-stable, because it prevents >>>> those DOM's from working in v5.15.5+. >>>> >>>> Ok. I must have missed that part when I read submitting-patches doc. >>>> >>>> I'll rework and re-submit the patch. >>> >>> I sent you a draft patch. Please try it. >> >> Works like a charm. >> >>> Also, to confirm if the log directory log page is indeed the page that locks up >>> the drive, can you try this command: >>> >>> sg_sat_read_gplog --dma --log=0 --page=0 --readonly >> >> # sg_sat_read_gplog --dma --log=0 --page=0 --readonly /dev/sda >> ATA PASS-THROUGH (16), bad field in cdb >> sg_sat_read_gplog failed: Illegal request >> >>> and >>> >>> sg_sat_read_gplog --log=0 --page=0 --readonly >> >> # sg_sat_read_gplog --log=0 --page=0 --readonly /dev/sda >> 00 0000 0000 0000 0000 0000 0000 0000 0000 .. .. .. .. .. .. .. .. >> 08 0000 0000 0000 0000 0000 0000 0000 0000 .. .. .. .. .. .. .. .. >> 10 0000 0000 0000 0000 0000 0000 0000 0000 .. .. .. .. .. .. .. .. >> 18 0000 0000 0000 0000 0000 0000 0000 0000 .. .. .. .. .. .. .. .. >> 20 0000 0000 0000 0000 0000 0000 0000 0000 .. .. .. .. .. .. .. .. >> 28 0000 0000 0000 0000 0000 0000 0000 0000 .. .. .. .. .. .. .. .. >> 30 0000 0000 0000 0000 0000 0000 0000 0000 .. .. .. .. .. .. .. .. >> 38 0000 0000 0000 0000 0000 0000 0000 0000 .. .. .. .. .. .. .. .. >> 40 0000 0000 0000 0000 0000 0000 0000 0000 .. .. .. .. .. .. .. .. >> 48 0000 0000 0000 0000 0000 0000 0000 0000 .. .. .. .. .. .. .. .. >> 50 0000 0000 0000 0000 0000 0000 0000 0000 .. .. .. .. .. .. .. .. >> 58 0000 0000 0000 0000 0000 0000 0000 0000 .. .. .. .. .. .. .. .. >> 60 0000 0000 0000 0000 0000 0000 0000 0000 .. .. .. .. .. .. .. .. >> 68 0000 0000 0000 0000 0000 0000 0000 0000 .. .. .. .. .. .. .. .. >> 70 0000 0000 0000 0000 0000 0000 0000 0000 .. .. .. .. .. .. .. .. >> 78 0000 0000 0000 0000 0000 0000 0000 0000 .. .. .. .. .. .. .. .. >> 80 0000 0000 0000 0000 0000 0000 0000 0000 .. .. .. .. .. .. .. .. >> 88 0000 0000 0000 0000 0000 0000 0000 0000 .. .. .. .. .. .. .. .. >> 90 0000 0000 0000 0000 0000 0000 0000 0000 .. .. .. .. .. .. .. .. >> 98 0000 0000 0000 0000 0000 0000 0000 0000 .. .. .. .. .. .. .. .. >> a0 0000 0000 0000 0000 0000 0000 0000 0000 .. .. .. .. .. .. .. .. >> a8 0000 0000 0000 0000 0000 0000 0000 0000 .. .. .. .. .. .. .. .. >> b0 0000 0000 0000 0000 0000 0000 0000 0000 .. .. .. .. .. .. .. .. >> b8 0000 0000 0000 0000 0000 0000 0000 0000 .. .. .. .. .. .. .. .. >> c0 0000 0000 0000 0000 0000 0000 0000 0000 .. .. .. .. .. .. .. .. >> c8 0000 0000 0000 0000 0000 0000 0000 0000 .. .. .. .. .. .. .. .. >> d0 0000 0000 0000 0000 0000 0000 0000 0000 .. .. .. .. .. .. .. .. >> d8 0000 0000 0000 0000 0000 0000 0000 0000 .. .. .. .. .. .. .. .. >> e0 0000 0000 0000 0000 0000 0000 0000 0000 .. .. .. .. .. .. .. .. >> e8 0000 0000 0000 0000 0000 0000 0000 0000 .. .. .. .. .. .. .. .. >> f0 0000 0000 0000 0000 0000 0000 0000 0000 .. .. .. .. .. .. .. .. >> f8 0000 0000 0000 0000 0000 0000 0000 0000 .. .. .. .. .. .. .. .. >> >> Mind you, this with a patched kernel, if that affects anything. > > Without a patched kernel, (grabbed os with a 4.19.94 kernel) the command > hangs for a while: > > # time sg_sat_read_gplog --log=0 --page=0 --readonly /dev/sda > ATA PASS-THROUGH (16), bad field in cdb > sg_sat_read_gplog failed: Illegal request > > real 0m28.337s > user 0m0.000s > sys 0m0.001s > > and logs the following in the kernel log: > > ata1: SATA link up 6.0 Gbps (SStatus 133 SControl 300) > ata1.00: failed to IDENTIFY (INIT_DEV_PARAMS failed, err_mask=0x80) > ata1.00: revalidation failed (errno=-5) > ata1: SATA link up 6.0 Gbps (SStatus 133 SControl 300) > ata1.00: configured for UDMA/133 > > > But after that 30s walkabout and whatever the kernel does the device > starts functioning again. The 30s "hang" is the default command timeout: your drive is not responding to the DMA version of READ LOG EXT command. There are some drives out there like that. So instead of completely disabling access to the log directory, we should simply force the use of READ LOG EXT. And for that, there is the horkage flag ATA_HORKAGE_NO_DMA_LOG. Can you try using that one without the patch I sent ? -- Damien Le Moal Western Digital Research