Re: [PATCH 1/3] ata: libata: Move quirk flags to their own enum

[Damien Le Moal <dlemoal@kernel.org>]

On 11/24/25 10:44 PM, Niklas Cassel wrote:
> The anonymous enum in include/linux/libata.h that is used to store various
> global constants can currently be backed by type int.
> (It contains both negative and positive constants.)
> 
> __ATA_QUIRK_MAX is currently 31.
> The quirk flags in the various global constants enum are defined as
> "1U << quirk_flag_bit".
> 
> Thus if we simply add an additional quirk, the quirk flag will be 1 << 31,
> which is a value that is too large to be represented by a signed int.
> The various global constants enum will thus therefore be backed by type
> long.
> 
> This will lead to error prints like e.g.:
> ata_port_err(ap, "EH pending after %d tries, giving up\n",
> 	     ATA_EH_MAX_TRIES);
> 
> now failing to build, with build error:
> error: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘long int’ [-Werror=format=]
> 
> This is because all other constants in the various global constants enum
> now has to be printed as a long.
> 
> Move the quirk flags to a separate enum, so that we don't need to change
> the printf specifier for all other constants in the "various global
> constants" enum when adding an additional quirk.
> 
> Signed-off-by: Niklas Cassel <cassel@kernel.org>

Looks good.

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>

-- 
Damien Le Moal
Western Digital Research