From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org
Cc: kernel test robot <lkp@intel.com>,
David Daney <ddaney@caviumnetworks.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH] ata: pata_octeon_cf: drop kernel-doc notation
Date: Tue, 14 Feb 2023 13:33:23 +0300 [thread overview]
Message-ID: <7c2f9a86-fa86-c1e2-25f8-1dd7c2350f69@gmail.com> (raw)
In-Reply-To: <dafa3a1f-3661-72d3-6423-22e8399b333f@opensource.wdc.com>
On 2/14/23 12:27 PM, Damien Le Moal wrote:
[...]
>>> Hm, why didn't you CC me?
>>>
>>> On 2/14/23 12:25 AM, Randy Dunlap wrote:
>>>
>>>> Fix a slew of kernel-doc warnings in pata_octeon_cf.c by changing
>>>> all "/**" comments to "/*" since they are not in kernel-doc format.
>>>>
>>>> Fixes: 3c929c6f5aa7 ("libata: New driver for OCTEON SOC Compact Flash interface (v7).")
>>>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>>>> Reported-by: kernel test robot <lkp@intel.com>
>>>> Link: https://lore.kernel.org/all/202302101722.5O56RClE-lkp@intel.com/
>>>> Cc: David Daney <ddaney@caviumnetworks.com>
>>>> Cc: Damien Le Moal <damien.lemoal@opensource.wdc.com>
>>>> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
>>>> Cc: linux-ide@vger.kernel.org
>>>
>>> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>>
>> Oops, replied from a wrong account... :-/
>> Damien, please let me know if you need this fixed...
>
> Nope. That is fine. A review is a review :)
> I can fix it with your usual email if you prefer though.
Well, the OMP's address is correct and listed in MAINTAINERS. It's the address
I replied from that was wrong. Some pepole (like GregKH) want From: and SoB to match...
MBR, Sergey
prev parent reply other threads:[~2023-02-14 10:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 21:25 [PATCH] ata: pata_octeon_cf: drop kernel-doc notation Randy Dunlap
2023-02-14 3:29 ` Damien Le Moal
2023-02-14 8:33 ` Sergei Shtylyov
2023-02-14 8:35 ` Sergei Shtylyov
2023-02-14 9:27 ` Damien Le Moal
2023-02-14 10:33 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c2f9a86-fa86-c1e2-25f8-1dd7c2350f69@gmail.com \
--to=sergei.shtylyov@gmail.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=ddaney@caviumnetworks.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mchehab@kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox