From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>,
<linux-ide@vger.kernel.org>
Subject: Re: [PATCH v2 0/2] Fix sloppy 'timeout' parameter type in libata-core.c
Date: Wed, 15 Jun 2022 22:49:09 +0300 [thread overview]
Message-ID: <7da76e0a-3805-6e33-def2-3846a2f3c8a8@omp.ru> (raw)
In-Reply-To: <20220615193821.9235-1-s.shtylyov@omp.ru>
On 6/15/22 10:38 PM, Sergey Shtylyov wrote:
> The libata code too often uses the *unsigned long* type for the millisecond
> timeouts, while the kernel functions like msecs_to_jiffies() or msleep() only
> take *unsigned int* parameters for those. Start fixing the timeout types from
> ata_exec_internal[_sg]() that triggered the SVACE static analyzer; there's
> going to be a large continuation series somewhat later...
>
> Sergey Shtylyov (2):
> ata: libata-core: make ata_exec_internal_sg() *static*
> ata: libata-core: fix sloppy parameter type in ata_exec_internal[_sg]()
>
> drivers/ata/libata-core.c | 12 ++++++------
> drivers/ata/libata.h | 6 +-----
> 2 files changed, 7 insertions(+), 11 deletions(-)
Forgot to mention the patches are against the 'for-next' branch of Damien's
'libata.git' repo... :-/
MBR, Sergey
prev parent reply other threads:[~2022-06-15 20:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 19:38 [PATCH v2 0/2] Fix sloppy 'timeout' parameter type in libata-core.c Sergey Shtylyov
2022-06-15 19:38 ` [PATCH v2 1/2] ata: libata-core: make ata_exec_internal_sg() *static* Sergey Shtylyov
2022-06-17 7:48 ` Damien Le Moal
2022-06-15 19:38 ` [PATCH v2 2/2] ata: libata-core: fix sloppy parameter type in ata_exec_internal[_sg]() Sergey Shtylyov
2022-06-17 7:44 ` Damien Le Moal
2022-06-17 17:27 ` Sergey Shtylyov
2022-06-18 6:45 ` Damien Le Moal
2022-06-18 19:49 ` Sergey Shtylyov
2022-06-19 23:23 ` Damien Le Moal
2022-06-15 19:49 ` Sergey Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7da76e0a-3805-6e33-def2-3846a2f3c8a8@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=damien.lemoal@opensource.wdc.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox