From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Hartgers Subject: Re: [patch 2/2] sata_via: Delay on vt6420 when starting ATAPI DMA write Date: Wed, 20 Jan 2010 07:44:07 +0100 Message-ID: <7eb6a4d81001192244k19d28805p9cb4eaec7eed9366@mail.gmail.com> References: <20100116235653.898098245@gmail.com> <20100116235851.884756038@gmail.com> <4B5678E2.2050709@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from ey-out-2122.google.com ([74.125.78.24]:25728 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753025Ab0ATGoJ convert rfc822-to-8bit (ORCPT ); Wed, 20 Jan 2010 01:44:09 -0500 In-Reply-To: <4B5678E2.2050709@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: linux-kernel@vger.kernel.org, Jeff Garzik , linux-ide@vger.kernel.org, juergen.metzdorf@telelev-dsl.de, markpschool@hotmail.com, sporadic.crash@gmail.com, apopov@sirma.bg, david@coomber.co.za, jay4mail@gmail.com Hi, 2010/1/20 Tejun Heo : > Hello, > > On 01/17/2010 08:56 AM, Bart Hartgers wrote: >> When writing a disc on certain lite-on dvd-writers (also rebadged as >> optiarc/LG/...) connected to a vt6420, the ATAPI CDB ends up in the >> datastream and on the disc, causing silent corruption. =C2=A0Delayin= g >> between sending the CDB and starting DMA seems to prevent this. >> >> I do not know if there are burners that do not suffer from this, but >> the patch should be safe for those as well. >> >> There are many reports of this issue, but AFAICT no solution was >> found before. For example: >> http://lkml.indiana.edu/hypermail/linux/kernel/0802.3/0561.html >> >> Signed-off-by: Bart Hartgers > > Ah... you found solution for this? =C2=A0That's great. =C2=A0This is = one of the > three problems that have been lingering for years - the other two > being pata_ali ATAPI DMA problem and sata_sil data corruption problem= =2E > I'll be ecstatic if this fix works. =C2=A0Just one thing, I don't thi= nk > we'll need a warning message there. =C2=A0It's useful during developm= ent > but it doesn't really provide any useful information afterwards. > Yes, you're right. I'll drop the printk_once and send another patch for inclusion. However, for testing I found it very useful to make sure that I got the right module loaded. So I figured it could be helpful for the interpretation of success/failure reports. Assuming that this patch works for other people as well, what is prefered: resending both patches or just to make a new #2/2 (the vt6420 one)? Groeten, Bart > Digging up the mailing list and cc'ing people who have reported this > problem. =C2=A0If you still have the affected systems, can you guys p= lease > test the patch in the following message and see whether it fixes the > problem? > > =C2=A0http://article.gmane.org/gmane.linux.kernel/939112/raw > > Thanks a lot. =C2=A0:-) > > -- > tejun > --=20 Bart Hartgers - New e-mail: bart.hartgers@gmail.com