From: Damien Le Moal <dlemoal@kernel.org>
To: Matt Vollrath <tactii@gmail.com>, Niklas Cassel <cassel@kernel.org>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
Hannes Reinecke <hare@suse.de>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] ata: libata-eh: Increase STANDBY IMMEDIATE timeout
Date: Mon, 27 Jul 2026 10:48:31 +0900 [thread overview]
Message-ID: <838ba900-1510-4fab-8ccc-3331ffcc332f@kernel.org> (raw)
In-Reply-To: <20260724073942.1751381-1-tactii@gmail.com>
On 7/24/26 16:39, Matt Vollrath wrote:
> Correct a previous change (see Fixes) which reduced the standby timeout
> from 30 to 5 seconds. Increase it to 15 seconds.
>
> I was troubleshooting an error spotted during system suspend:
>
> [ 1217.152867] ata1.00: Entering standby power mode
> [ 1222.322948] ata1.00: qc timeout after 5000 msecs (cmd 0xe0)
> [ 1222.324010] ata1.00: STANDBY IMMEDIATE failed (err_mask=0x4)
>
> This drive is a Samsung 870 EVO SSD in good SMART standing, and I wasn't
> aware of any reason it should be taking so long to standby. The issue is
> intermittent, but I observed it sometimes taking 7 seconds to manually
> standby. I assume this was interruption of background maintenance after
> a power outage.
>
> As a desktop user, I would prefer to wait the extra 2 seconds at suspend
> to let the drive finish its business rather than drop the rails from
> under it.
>
> The change from 30 to 5 seconds was implicit when switching suspend
> from START STOP UNIT to an internal command with no timeout table entry.
> No reason was stated for the change.
>
> Fixes: aa3998dbeb3a ("ata: libata-scsi: Disable scsi device manage_system_start_stop")
> Cc: stable@vger.kernel.org
> Signed-off-by: Matt Vollrath <tactii@gmail.com>
> Assisted-by: Claude:claude-5-fable
Applied to for-7.2-fixes. Thanks!
--
Damien Le Moal
Western Digital Research
prev parent reply other threads:[~2026-07-27 1:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 7:39 [PATCH] ata: libata-eh: Increase STANDBY IMMEDIATE timeout Matt Vollrath
2026-07-27 1:48 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838ba900-1510-4fab-8ccc-3331ffcc332f@kernel.org \
--to=dlemoal@kernel.org \
--cc=cassel@kernel.org \
--cc=hare@suse.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stable@vger.kernel.org \
--cc=tactii@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).