Re: [PATCH v3 13/23] ata: libahci: Extend port-cmd flags set with port capabilities

Serge Semin
2022-05-13T12:13:41Z

On Fri, May 13, 2022 at 11:22:44AM +0300, Sergei Shtylyov wrote:
> On 5/12/22 2:18 AM, Serge Semin wrote:
>
> > Currently not all of the Port-specific capabilities listed in the
> > PORT_CMD-enumeration. Let's extend that set with the Cold Presence
> > Detection and Mechanical Presence Switch attached to the Port flags [1] so
> > to closeup the set of the platform-specific port-capabilities flags. Note
> > these flags are supposed to be set by the platform firmware if there is
> > one. Alternatively as we are about to do they can be set by means of the
> > OF properties.
> >
> > While at it replace PORT_IRQ_DEV_ILCK with PORT_IRQ_DEV_MPS and fix the
>

> Your code has PORT_IRQ_DMPS instead...

Right. The correct macro name is used in the patch body. I'll fix the
log. Thanks.

-Sergey

>
> > comment there. In accordance with [2] that IRQ flag is supposed to
> > indicate the state of the signal coming from the Mechanical Presence
> > Switch.
> >
> > [1] Serial ATA AHCI 1.3.1 Specification, p.27
> > [2] Serial ATA AHCI 1.3.1 Specification, p.7
> >
> > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> > ---
> > drivers/ata/ahci.h | 7 ++++++-
> > 1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/ata/ahci.h b/drivers/ata/ahci.h
> > index 7d834deefeb9..f501531bd1b3 100644
> > --- a/drivers/ata/ahci.h
> > +++ b/drivers/ata/ahci.h
> > @@ -138,7 +138,7 @@ enum {
> > PORT_IRQ_BAD_PMP = (1 << 23), /* incorrect port multiplier */
> >
> > PORT_IRQ_PHYRDY = (1 << 22), /* PhyRdy changed */
> > - PORT_IRQ_DEV_ILCK = (1 << 7), /* device interlock */
> > + PORT_IRQ_DMPS = (1 << 7), /* mechanical presence status */
> > PORT_IRQ_CONNECT = (1 << 6), /* port connect change status */
> > PORT_IRQ_SG_DONE = (1 << 5), /* descriptor processed */
> > PORT_IRQ_UNK_FIS = (1 << 4), /* unknown FIS rx'd */
> [...]
>
> MBR, Sergey