From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: Niklas Cassel <Niklas.Cassel@wdc.com>
Cc: Mikael Pettersson <mikpelinux@gmail.com>,
"john.garry@huawei.com" <john.garry@huawei.com>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: Re: [PATCH 2/4] ata: make use of ata_port_is_frozen() helper
Date: Sat, 8 Oct 2022 08:56:16 +0900 [thread overview]
Message-ID: <850610de-423f-1ff3-077a-2243cd012005@opensource.wdc.com> (raw)
In-Reply-To: <Y0C7TcSfZezZxMcX@x1-carbon>
On 10/8/22 08:50, Niklas Cassel wrote:
> On Sat, Oct 08, 2022 at 07:31:00AM +0900, Damien Le Moal wrote:
>> On 10/7/22 22:23, Niklas Cassel wrote:
>>> Clean up the code by making use of the newly introduced
>>> ata_port_is_frozen() helper function.
>>
>> Looks good, but I think this should be squashed with patch 1.
>
> I could, but by that same logic, shouldn't patch 3/4 also be squashed into
> patch 1?
Well, I didn't get patch 3 :)
Looking at it now, since patch 3 are changes for libsas, better keep it a
separate patch, and we can see with Martin which tree to use to queue it
(it probably should go through the ata tree).
>
>
> Kind regards,
> Niklas
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2022-10-07 23:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-07 13:23 [PATCH 0/4] libata: misc frozen port cleanups Niklas Cassel
2022-10-07 13:23 ` [PATCH 1/4] ata: add ata_port_is_frozen() helper Niklas Cassel
2022-10-10 7:00 ` John Garry
2022-10-10 10:17 ` Niklas Cassel
2022-10-10 11:22 ` John Garry
2022-10-11 0:32 ` Damien Le Moal
2022-10-07 13:23 ` [PATCH 2/4] ata: make use of " Niklas Cassel
2022-10-07 22:31 ` Damien Le Moal
2022-10-07 23:50 ` Niklas Cassel
2022-10-07 23:56 ` Damien Le Moal [this message]
2022-10-08 0:09 ` Niklas Cassel
2022-10-07 13:23 ` [PATCH 4/4] ata: libata-core: do not retry reading the log on timeout Niklas Cassel
2022-10-07 22:33 ` Damien Le Moal
2022-10-07 23:47 ` Niklas Cassel
2022-10-07 23:52 ` Damien Le Moal
2022-10-10 17:10 ` Niklas Cassel
2022-10-18 4:59 ` [PATCH 0/4] libata: misc frozen port cleanups Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=850610de-423f-1ff3-077a-2243cd012005@opensource.wdc.com \
--to=damien.lemoal@opensource.wdc.com \
--cc=Niklas.Cassel@wdc.com \
--cc=john.garry@huawei.com \
--cc=linux-ide@vger.kernel.org \
--cc=mikpelinux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox