From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps.thesusis.net (vps.thesusis.net [34.202.238.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80C4D45941 for ; Mon, 8 Jan 2024 13:39:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=thesusis.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=thesusis.net Received: by vps.thesusis.net (Postfix, from userid 1000) id AECDA1524F8; Mon, 8 Jan 2024 08:39:04 -0500 (EST) From: Phillip Susi To: Damien Le Moal , linux-ide@vger.kernel.org Cc: Sergey Shtylyov Subject: Re: [PATCH 3/3] libata: don't start PuiS disks on resume In-Reply-To: References: <87msthdo11.fsf@vps.thesusis.net> <20240107180258.360886-1-phill@thesusis.net> <20240107180258.360886-4-phill@thesusis.net> Date: Mon, 08 Jan 2024 08:39:04 -0500 Message-ID: <871qasuepz.fsf@vps.thesusis.net> Precedence: bulk X-Mailing-List: linux-ide@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Damien Le Moal writes: > Please use full 72-char lines for commit messages. The commit message also does > not clearly describe what the patch does (completely silent on forcing the drive > to sleep). It currently doesn't put it to sleep. >> +#if 0 >> + ata_tf_init(dev, &tf); >> + tf.flags |= ATA_TFLAG_DEVICE | ATA_TFLAG_ISADDR; >> + tf.protocol = ATA_PROT_NODATA; >> + tf.command = ATA_CMD_SLEEP; >> + err_mask = ata_exec_internal(dev, &tf, NULL, DMA_NONE, NULL, 0, 0); >> + ata_dev_info(dev, "PuiS detected, putting drive to sleep"); > > I already commented that this is not following the ACS specifications and thus > should not be done. So again, nack. It is #if 0'd out. I also addressed this in the cover letter. Sure, this shouldn't be done by default, but I don't see a problem with leaving it as an option that can be activated by those whose drives don't have a problem with this.