From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps.thesusis.net (vps.thesusis.net [34.202.238.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1EEB544C9D for ; Mon, 8 Jan 2024 13:30:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=thesusis.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=thesusis.net Received: by vps.thesusis.net (Postfix, from userid 1000) id 49C441524E0; Mon, 8 Jan 2024 08:30:20 -0500 (EST) From: Phillip Susi To: Sergey Shtylyov , linux-ide@vger.kernel.org Cc: Damien Le Moal Subject: Re: [PATCH 1/3] libata: avoid waking disk for several commands In-Reply-To: <14fbc9fa-0876-23c7-b4d3-46a431c2de40@omp.ru> References: <87msthdo11.fsf@vps.thesusis.net> <20240107180258.360886-1-phill@thesusis.net> <20240107180258.360886-2-phill@thesusis.net> <14fbc9fa-0876-23c7-b4d3-46a431c2de40@omp.ru> Date: Mon, 08 Jan 2024 08:30:20 -0500 Message-ID: <875y04uf4j.fsf@vps.thesusis.net> Precedence: bulk X-Mailing-List: linux-ide@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Sergey Shtylyov writes: > Did you run your patches thru scripts/checkpatch.pl? Looking > at this patch, I think you didn't... :-) Will do. > This can't happen, you forgot: > > case ATA_CMD_ID_ATA: Woops.. that must have gotten lost somehow when I was cutting and pasting to avoid the fallthrough.