[PATCH] IDE: typo in ide-io.c leads to faulty assignment

[PATCH] IDE: typo in ide-io.c leads to faulty assignment

[Elias Oltmanns]

[-- Attachment #1: Type: text/plain, Size: 258 bytes --]

Due to a typo in ide_start_power_step, the result of a function rather
than its pointer is assigned to args->handler. The patch applies to
2.6.19-rc6 but the problem exists in the stable branch as well.

Signed-off-by: Elias Oltmanns <eo@nebensachen.de>
---

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: ide-io.c.patch --]
[-- Type: text/x-patch, Size: 542 bytes --]

diff --git a/drivers/ide/ide-io.c b/drivers/ide/ide-io.c
index 2614f41..48a249d 100644
--- a/drivers/ide/ide-io.c
+++ b/drivers/ide/ide-io.c
@@ -213,7 +213,7 @@ static ide_startstop_t ide_start_power_s
 	case idedisk_pm_idle:		/* Resume step 2 (idle) */
 		args->tfRegister[IDE_COMMAND_OFFSET] = WIN_IDLEIMMEDIATE;
 		args->command_type = IDE_DRIVE_TASK_NO_DATA;
-		args->handler = task_no_data_intr;
+		args->handler = &task_no_data_intr;
 		return do_rw_taskfile(drive, args);
 
 	case ide_pm_restore_dma:	/* Resume step 3 (restore DMA) */

Re: [PATCH] IDE: typo in ide-io.c leads to faulty assignment

[Alan]

On Mon, 27 Nov 2006 15:51:33 +0100
Elias Oltmanns <eo@nebensachen.de> wrote:

> Due to a typo in ide_start_power_step, the result of a function rather
> than its pointer is assigned to args->handler.

NAK

If it was the result of the function it would end with (arguments);

Alan

Re: [PATCH] IDE: typo in ide-io.c leads to faulty assignment

[Jesper Juhl]

On 27/11/06, Elias Oltmanns <eo@nebensachen.de> wrote:
> Due to a typo in ide_start_power_step, the result of a function rather
> than its pointer is assigned to args->handler. The patch applies to
> 2.6.19-rc6 but the problem exists in the stable branch as well.
>

These two lines :

-		args->handler = task_no_data_intr;
+		args->handler = &task_no_data_intr;

do the same thing.

-- 
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html

Re: [PATCH] IDE: typo in ide-io.c leads to faulty assignment

[Elias Oltmanns]

"Jesper Juhl" <jesper.juhl@gmail.com> wrote:
> These two lines :
>
> -		args->handler = task_no_data_intr;
> +		args->handler = &task_no_data_intr;
>
> do the same thing.

Thanks for explaining, obviously I got a bit confused.

Sorry for the noise.

Elias