* [PATCH 2.4.29] libata: fix ata_piix on ICH6R in RAID mode
@ 2005-02-02 3:26 Martins Krikis
2005-02-06 5:06 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Martins Krikis @ 2005-02-02 3:26 UTC (permalink / raw)
To: jgarzik; +Cc: linux-kernel, linux-ide, alan, mkrikis
Jeff,
Here is the cleaned up patch (as you suggested)
that enables ata_piix to work in RAID mode on ICH6R.
I tested it and it seems to behave correctly
in all the modes---sees all 4 disks in IDE and RAID modes,
doesn't see any in Compatibility mode (which is right,
because only two are available and the regular IDE driver
has picked them up already).
Signed-off-by: Martins Krikis <mkrikis@yahoo.com>
--- linux-2.4.29/drivers/scsi/libata-core.c 2005-01-25 20:55:41.000000000 -0500
+++ linux-2.4.29-iswraid/drivers/scsi/libata-core.c 2005-02-01 20:23:51.000000000 -0500
@@ -3597,7 +3597,8 @@ int ata_pci_init_one (struct pci_dev *pd
else
port[1] = port[0];
- if ((port[0]->host_flags & ATA_FLAG_NO_LEGACY) == 0) {
+ if ((port[0]->host_flags & ATA_FLAG_NO_LEGACY) == 0
+ && (pdev->class >> 8) == PCI_CLASS_STORAGE_IDE) {
/* TODO: support transitioning to native mode? */
pci_read_config_byte(pdev, PCI_CLASS_PROG, &tmp8);
mask = (1 << 2) | (1 << 0);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2.4.29] libata: fix ata_piix on ICH6R in RAID mode
2005-02-02 3:26 [PATCH 2.4.29] libata: fix ata_piix on ICH6R in RAID mode Martins Krikis
@ 2005-02-06 5:06 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2005-02-06 5:06 UTC (permalink / raw)
To: Martins Krikis; +Cc: linux-kernel, linux-ide, alan
Martins Krikis wrote:
> --- linux-2.4.29/drivers/scsi/libata-core.c 2005-01-25 20:55:41.000000000 -0500
> +++ linux-2.4.29-iswraid/drivers/scsi/libata-core.c 2005-02-01 20:23:51.000000000 -0500
> @@ -3597,7 +3597,8 @@ int ata_pci_init_one (struct pci_dev *pd
> else
> port[1] = port[0];
>
> - if ((port[0]->host_flags & ATA_FLAG_NO_LEGACY) == 0) {
> + if ((port[0]->host_flags & ATA_FLAG_NO_LEGACY) == 0
> + && (pdev->class >> 8) == PCI_CLASS_STORAGE_IDE) {
> /* TODO: support transitioning to native mode? */
> pci_read_config_byte(pdev, PCI_CLASS_PROG, &tmp8);
> mask = (1 << 2) | (1 << 0);
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-02-06 5:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-02 3:26 [PATCH 2.4.29] libata: fix ata_piix on ICH6R in RAID mode Martins Krikis
2005-02-06 5:06 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).