Re: [PATCH 0/3] ide: /proc/ide/hd*/settings rework

[Elias Oltmanns <eo@nebensachen.de>]

Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:
> Hi,
>
> I finally dusted off /proc/ide/hd*/settings rework (this has been laying
> on my hdd and waiting for the better days for at least 1.5 year, draft
> version even longer like ~3 years... sigh).
>
> The main motivation for doing it is that with infrastructure for private
> IDE subsystem requests from Elias Oltmanns (which was merged recently)
> and this patchset it should be possible (by using private requests for
> device settings) to make IDE locking code a lot saner and get rid of
> of ide_spin_wait_hwgroup()-ugliness completely.
>
> Elias if you would like to take care of it please go ahead [ from a quick
> look it seems this would mostly require adding new request type, pointing
> rq->special to setting's ->get or ->set method and putting setting's type
> (read/write -> 1 bit) + argument (int) somewhere inside request but you
> probably know better ].

Yes, I'll have a go at it. I haven't quite figured out yet whether I can
(or should, for that matter) get rid of drive->special and convert the
rest accordingly.

Anyway, I probably won't get it done before next week.

Regards,

Elias