From: Damien Le Moal <dlemoal@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Niklas Cassel" <cassel@kernel.org>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] ata: Switch back to struct platform_driver::remove()
Date: Thu, 17 Oct 2024 09:34:47 +0900 [thread overview]
Message-ID: <8854fd2e-c8d5-4308-893a-0cf14da03ffe@kernel.org> (raw)
In-Reply-To: <20241016141609.27329-2-u.kleine-koenig@baylibre.com>
On 10/16/24 23:16, Uwe Kleine-König wrote:
> After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
> return void") .remove() is (again) the right callback to implement for
> platform drivers.
>
> Convert all platform drivers below drivers/ata/ to use .remove(), with
> the eventual goal to drop struct platform_driver::remove_new(). As
> .remove() and .remove_new() have the same prototypes, conversion is done
> by just changing the structure member name in the driver initializer.
>
> While touching these files, make indention of the struct initializer
> consistent in several files.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Looks good.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2024-10-17 0:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 14:16 [PATCH] ata: Switch back to struct platform_driver::remove() Uwe Kleine-König
2024-10-17 0:34 ` Damien Le Moal [this message]
2024-10-17 8:14 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8854fd2e-c8d5-4308-893a-0cf14da03ffe@kernel.org \
--to=dlemoal@kernel.org \
--cc=cassel@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox