public inbox for linux-ide@vger.kernel.org
 help / color / mirror / Atom feed
From: Damien Le Moal <dlemoal@kernel.org>
To: Niklas Cassel <cassel@kernel.org>, Hannes Reinecke <hare@suse.de>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Ilia Baryshnikov <qwelias@gmail.com>, linux-ide@vger.kernel.org
Subject: Re: [PATCH 2/2] ata: libata-core: Set capacity to zero for a security locked drive
Date: Thu, 20 Nov 2025 12:31:19 +0900	[thread overview]
Message-ID: <8a361a94-eaf5-4ebb-9c77-9cbc25b82cc3@kernel.org> (raw)
In-Reply-To: <20251119141313.2220084-4-cassel@kernel.org>

On 11/19/25 11:13 PM, Niklas Cassel wrote:
> For Security locked drives (drives that have Security enabled, and have
> not been Security unlocked by boot firmware), the automatic partition
> scanning will result in the user being spammed with errors such as:
> 
>   ata5.00: failed command: READ DMA
>   ata5.00: cmd c8/00:08:00:00:00/00:00:00:00:00/e0 tag 7 dma 4096 in
>            res 51/04:08:00:00:00/00:00:00:00:00/e0 Emask 0x1 (device error)
>   ata5.00: status: { DRDY ERR }
>   ata5.00: error: { ABRT }
>   sd 4:0:0:0: [sda] tag#7 FAILED Result: hostbyte=DID_OK driverbyte=DRIVER_OK cmd_age=0s
>   sd 4:0:0:0: [sda] tag#7 Sense Key : Aborted Command [current]
>   sd 4:0:0:0: [sda] tag#7 Add. Sense: No additional sense information
> 
> during boot, because most commands except for IDENTIFY will be aborted by
> a Security locked drive.
> 
> For a Security locked drive, set capacity to zero, so that no automatic
> partition scanning will happen.
> 
> If the user later unlocks the drive using e.g. hdparm, the close() by the
> user space application should trigger a revalidation of the drive.
> 
> Signed-off-by: Niklas Cassel <cassel@kernel.org>

Looks good.

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>

-- 
Damien Le Moal
Western Digital Research

  reply	other threads:[~2025-11-20  3:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-19 14:13 [PATCH 1/2] ata: libata-scsi: Fix system suspend for a security locked drive Niklas Cassel
2025-11-19 14:13 ` [PATCH 2/2] ata: libata-core: Set capacity to zero " Niklas Cassel
2025-11-20  3:31   ` Damien Le Moal [this message]
2025-11-20  3:49   ` Martin K. Petersen
2025-11-20  7:24   ` Hannes Reinecke
2025-11-20  3:29 ` [PATCH 1/2] ata: libata-scsi: Fix system suspend " Damien Le Moal
2025-11-20  3:48 ` Martin K. Petersen
2025-11-20  7:24 ` Hannes Reinecke
2025-11-20 12:45 ` Niklas Cassel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a361a94-eaf5-4ebb-9c77-9cbc25b82cc3@kernel.org \
    --to=dlemoal@kernel.org \
    --cc=cassel@kernel.org \
    --cc=hare@suse.de \
    --cc=linux-ide@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=qwelias@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox