Re: [PATCH] ata: libata-core: Enable context analysis

[Bart Van Assche <bvanassche@acm.org>]

On 5/11/26 9:53 AM, Niklas Cassel wrote:
> 1) It seems that you are only checking for the EH mutex.
> 
> $ git grep -A 1 "LOCKING" drivers/ata/
> 
> Does have many functions with:
> 	LOCKING:
> 	spin_lock_irqsave(host lock)
> 
> Would it be possible to add __must_hold() annotations for these functions
> too, but for ap->lock instead of EH mutex ?

This is something I can't do myself. This is something that should be 
done by an ATA expert. I'm not an ATA expert.

> 2) There seems to be some files that did not get any annotations, e.g.
> drivers/ata/libata-scsi.c, drivers/ata/libata-sata.c,
> drivers/ata/libata-acpi.c, drivers/ata/libata-pmp.c.
> 
> Would it be possible to add annotations for these files too?

Just like for (1), since there are inconsistencies between the
"LOCKING:" documentation and the implementation, this is best done by
an ATA expert.

The goal of the annotations in this patch is to make sure that the build
doesn't break with CONTEXT_ANALYSIS := y. Any additional annotations can
be implemented as follow-up patches.

Thanks,

Bart.