Re: [PATCH] libata: make ata_host_suspend() *void*

[Hannes Reinecke <hare@suse.de>]

On 2/2/22 21:58, Sergey Shtylyov wrote:
> ata_host_suspend() always returns 0, so the result checks in many drivers
> look pointless.  Let's make this function return *void* instead of *int*.
> 
> Found by Linux Verification Center (linuxtesting.org) with the SVACE static
> analysis tool.
> 
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
> 
> ---
> This patch is against the 'for-next' branch of Damien Le Moal's 'libata.git'
> repo.
> 
>   drivers/ata/ahci.c             |    3 ++-
>   drivers/ata/ata_piix.c         |    5 +----
>   drivers/ata/libahci_platform.c |    3 ++-
>   drivers/ata/libata-core.c      |    8 ++------
>   drivers/ata/pata_arasan_cf.c   |    3 ++-
>   drivers/ata/pata_cs5520.c      |    5 +----
>   drivers/ata/pata_imx.c         |   15 ++++++---------
>   drivers/ata/pata_macio.c       |    6 +-----
>   drivers/ata/pata_mpc52xx.c     |    3 ++-
>   drivers/ata/pata_samsung_cf.c  |    3 ++-
>   drivers/ata/pata_triflex.c     |    5 +----
>   drivers/ata/sata_fsl.c         |    4 +++-
>   drivers/ata/sata_highbank.c    |    3 ++-
>   drivers/ata/sata_mv.c          |    6 +++---
>   drivers/ata/sata_rcar.c        |   18 ++++++++----------
>   include/linux/libata.h         |    2 +-
>   16 files changed, 39 insertions(+), 53 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer