From: Niklas Cassel <cassel@kernel.org>
To: Pawel Zalewski <pzalewski@thegoodpenguin.co.uk>
Cc: sashiko-reviews@lists.linux.dev, linux-ide@vger.kernel.org,
dlemoal@kernel.org
Subject: Re: [PATCH 1/2] ata: use named initializers for acpi_device_id
Date: Tue, 04 Aug 2026 09:01:09 +0200 [thread overview]
Message-ID: <90FE7BC8-5432-49C8-9748-E958E89FF25A@kernel.org> (raw)
In-Reply-To: <CAA6zWZJ_TCa4CyEGFd-a-u_NS=Dv64KV-HONhomER2PC7p+EyQ@mail.gmail.com>
On 4 August 2026 08:09:52 CEST, Pawel Zalewski <pzalewski@thegoodpenguin.co.uk> wrote:
>>I do kind of agree with Sashiko that ahci_seattle.c could have been fixed
>> in patch 1/2 (rather than fixing ahci_seattle.c in patch 2/2).
>
>Happy to refactor in V2 so that patch 2 would only deal with removing
>driver_data = 0
>in the ahci_seattle module.
>
I am usually the one who prefer things to be split into multiple patches.
But in this case, I think you can do everything in the same patch.
Still seems like the same logical change, clarifying/cleaning up the initializers.
Kind regards,
Niklas
next prev parent reply other threads:[~2026-08-04 7:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 15:03 [PATCH 0/2] ata: use named initializers for acpi_device_id Pawel Zalewski via B4 Relay
2026-08-03 15:03 ` [PATCH 1/2] " Pawel Zalewski via B4 Relay
2026-08-03 15:14 ` sashiko-bot
2026-08-03 19:58 ` Niklas Cassel
2026-08-04 6:09 ` Pawel Zalewski
2026-08-04 7:01 ` Niklas Cassel [this message]
2026-08-03 15:03 ` [PATCH 2/2] ata: ahci_seattle: drop unused acpi_device_id::driver_data Pawel Zalewski via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90FE7BC8-5432-49C8-9748-E958E89FF25A@kernel.org \
--to=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=pzalewski@thegoodpenguin.co.uk \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox