Linux ATA/IDE development
 help / color / mirror / Atom feed
From: Damien Le Moal <dlemoal@kernel.org>
To: Juergen Gross <jgross@suse.com>,
	linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Cc: Niklas Cassel <cassel@kernel.org>
Subject: Re: [PATCH v6 04/12] drivers/ata: Stop using 32-bit MSR interfaces
Date: Mon, 16 Nov 2026 07:10:51 -0800	[thread overview]
Message-ID: <932b724d-b062-4b99-aa25-6da2ac1c45e4@kernel.org> (raw)
In-Reply-To: <20261116150208.1572254-5-jgross@suse.com>

On 11/16/26 07:02, Juergen Gross wrote:
> The 32-bit MSR interfaces rdmsr() and wrmsr() are planned to be
> removed. Use the related 64-bit variants instead.
> 
> In drivers/ata/pata_cs5536.c don't redefine rdmsr() and wrmsr() as
> empty macros for avoiding misuse, but guard the affected code via
> a simple #ifdef.
> 
> Switch pio_cmd_timings[] to a u32 type array in order to avoid a cast
> to u32 when constructing final MSR values.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>
> Acked-by: Niklas Cassel <cassel@kernel.org>

Please change the patch title to be:

ata: pata_cs553X: Stop using 32-bit MSR interfaces

Other than that,

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>

-- 
Damien Le Moal
Western Digital Research

  reply	other threads:[~2026-11-16 15:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 15:01 [PATCH v6 00/12] x86/msr: Drop 32-bit MSR interfaces Juergen Gross
2026-11-16 15:02 ` [PATCH v6 04/12] drivers/ata: Stop using " Juergen Gross
2026-11-16 15:10   ` Damien Le Moal [this message]
2026-11-16 15:02 ` [PATCH v6 11/12] treewide: convert rdmsrq() from a macro to an inline function Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=932b724d-b062-4b99-aa25-6da2ac1c45e4@kernel.org \
    --to=dlemoal@kernel.org \
    --cc=cassel@kernel.org \
    --cc=jgross@suse.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox