Linux ATA/IDE development
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Sergey Shtylyov <s.shtylyov@omp.ru>,
	Sergey Shtylyov <s.shtylyov@omprussia.ru>,
	linux-ide@vger.kernel.org
Subject: Re: [PATCH v2] pata_ep93xx: fix deferred probing
Date: Thu, 27 May 2021 13:03:25 -0600	[thread overview]
Message-ID: <934957f3-ff80-ae1d-8839-d5ffe2a952d1@kernel.dk> (raw)
In-Reply-To: <946c838b-0a9f-dfd0-70ac-a0c67c57deea@omp.ru>

On 5/27/21 12:39 PM, Sergey Shtylyov wrote:
> Hello!
> 
> On 3/20/21 11:32 PM, Sergey Shtylyov wrote:
> 
>> The driver overrides the error codes returned by platform_get_irq() to
>> -ENXIO, so if it returns -EPROBE_DEFER, the driver would fail the probe
>> permanently instead of the deferred probing.  Propagate the error code
>> upstream, as it should have been done from the start...
>>
>> Fixes: 2fff27512600 ("PATA host controller driver for ep93xx")
>> Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
> 
>    Again, 2 months has passed and no feedback whatsoever... the patch has fell
> thru the cracks?

It'd help if you sent out patches like this in a series, instead of
individual ones, when they are addressing the same issue across
multiple drivers. Makes the risk of them getting lost much smaller.

That said, I'll apply this one, thanks.

-- 
Jens Axboe


  reply	other threads:[~2021-05-27 19:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-20 20:32 [PATCH v2] pata_ep93xx: fix deferred probing Sergey Shtylyov
2021-05-27 18:39 ` Sergey Shtylyov
2021-05-27 19:03   ` Jens Axboe [this message]
2021-05-27 19:10     ` Sergey Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=934957f3-ff80-ae1d-8839-d5ffe2a952d1@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=linux-ide@vger.kernel.org \
    --cc=s.shtylyov@omp.ru \
    --cc=s.shtylyov@omprussia.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox