From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 400122E3716; Thu, 31 Jul 2025 12:06:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=94.136.29.106 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753963593; cv=none; b=SIIw/FMM/Ueq6Xup+LYyQ/0lO/wXlf+laqDo9sF+WvNI/f7EVho9UpFQkF+RsRejtJ3RDSvnBgH4ZAPmmcBmi+dTSY4ZdhTT5uSlPcRuJhEgmmUoqW2uL9opPpDRHtqEHtB4asq/aTzlRqTcBwP3lo6bcZske4ZxGjO2XSbkDnQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753963593; c=relaxed/simple; bh=uJE7eqPcm9UN43lGyVjIORKLatwubUvuqXTRg8oyBSw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=U+kQ0+cQUOmRCXZGNl/CUAiH3fcgH5AJa8m40MEo0cYnp6Qynus5ZuKoK/gPEH6pCAnVFAblrXNE4u8nj5DVtUJbRCeGYLXLV5jP64tiHZEMTZ1mxcR+Onke0ScIjRrK1K6vaMIb8n7BMHVF8K6rBKUZUs/CeSFq7pOSvV7T9eQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=proxmox.com; spf=pass smtp.mailfrom=proxmox.com; arc=none smtp.client-ip=94.136.29.106 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=proxmox.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=proxmox.com Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EF9A6470F6; Thu, 31 Jul 2025 14:06:28 +0200 (CEST) Message-ID: <93bcd3a7-8054-4a40-8b19-83b30e4ce84e@proxmox.com> Date: Thu, 31 Jul 2025 14:06:28 +0200 Precedence: bulk X-Mailing-List: linux-ide@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 08/19] scsi: detect support for command duration limits To: Diangang Li , Damien Le Moal Cc: Mira Limbeck , Niklas Cassel , Jens Axboe , "Martin K. Petersen" , "James E.J. Bottomley" , Kashyap Desai , Sumit Saxena , Shivasharan S , Chandrakanth patil , Sathya Prakash Veerichetty , Sreekanth Reddy , megaraidlinux.pdl@broadcom.com, mpi3mr-linuxdrv.pdl@broadcom.com, Bart Van Assche , Christoph Hellwig , Hannes Reinecke , linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org, linux-block@vger.kernel.org, Niklas Cassel References: <3dee186c-285e-4c1c-b879-6445eb2f3edf@proxmox.com> <6fb8499a-b5bc-4d41-bf37-32ebdea43e9a@kernel.org> <2e7d6a7e-4a82-4da5-ab39-267a7400ca49@proxmox.com> <54e0a717-e9fc-4534-bc27-8bc1ee745048@kernel.org> <72bf0fd7-f646-46f7-a2aa-ef815dbfa4e2@proxmox.com> <3b2a6cfe-5bf3-4818-8633-c200d8e6f122@kernel.org> <4cb58e56-d9e2-4868-84ad-8b7253148228@proxmox.com> <75412b1b-3f39-4f6a-93ce-823c15a19bf3@kernel.org> <20250731114832.GA97414@bytedance.com> Content-Language: en-US From: Friedrich Weber In-Reply-To: <20250731114832.GA97414@bytedance.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753963575858 On 31/07/2025 13:48, Diangang Li wrote: > On Tue, Jul 22, 2025 at 06:37:50PM +0900, Damien Le Moal wrote: >> On 7/22/25 6:32 PM, Friedrich Weber wrote: >>> On 14/07/2025 04:48, Damien Le Moal wrote: >>>> On 7/10/25 5:41 PM, Friedrich Weber wrote: >>>>> Thanks for looking into this, it is definitely a strange problem. >>>>> >>>>> Considering these drives don't support CDL anyway: Do you think it would >>>>> be possible to provide an "escape hatch" to disable only the CDL checks >>>>> (a module parameter?) so hotplug can work for the user again for their >>>>> device? If I see correctly, disabling just the CDL checks is not >>>>> possible (without recompiling the kernel) -- scsi_mod.dev_flags can be >>>>> used to disable RSOC, but I guess that has other unintended consequences >>>>> too, so a more "targeted" escape hatch would be nice. >>>> >>>> Could you test the attached patch ? That should solve the issue. >>>> >>> >>> Thanks for the patch! The user tested it on top of a 6.15.6 kernel and >>> with the SAS3008 HBA, and indeed: >>> >>> - under 6.15.6, hotplug fails with the log messages mentioned in my >>> first message, >>> - with your patch on top, hotplug works again. >> >> OK. Will post a proper patch then (tomorrow). >> Thanks for testing. >> > > Hi Damien, > > Are you planning to post a formal patch to upstream? Damien did post a patch [1], but as discussed there [2], it was not effective in our case because it was targeted at SATA drives, and we realized all tests were actually done using SAS drives. Sorry for the confusion, it might have been better if I had posted my follow-up yesterday [3] in the other thread instead. [1] https://lore.kernel.org/all/20250723052334.32298-1-dlemoal@kernel.org/ [2] https://lore.kernel.org/all/a345c99d-864b-4dde-b755-b61a085508a8@proxmox.com/#t [3] https://lore.kernel.org/all/eb3778e5-dfdb-4382-8cc6-da6459f14a46@proxmox.com/