From: Damien Le Moal <dlemoal@kernel.org>
To: Hannes Reinecke <hare@suse.de>,
linux-ide@vger.kernel.org, Niklas Cassel <cassel@kernel.org>
Subject: Re: [PATCH 3/5] ata: libata-scsi: simplify ata_scsi_schedule_deferred_qc()
Date: Fri, 20 Feb 2026 06:38:58 +0900 [thread overview]
Message-ID: <93cd8b3e-b0ec-46e3-ae38-a29ee63cf3bf@kernel.org> (raw)
In-Reply-To: <3da46b3a-44d4-4c3d-9ca4-32089f36415c@suse.de>
On 2/19/26 17:21, Hannes Reinecke wrote:
> On 2/19/26 07:23, Damien Le Moal wrote:
>> Use ata_qc_done() instead of calling ata_qc_free() and scsi_done()
>> directly.
>>
>> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
>> ---
>> drivers/ata/libata-scsi.c | 7 ++-----
>> 1 file changed, 2 insertions(+), 5 deletions(-)
>>
> As noted by Sergey, the description refers to the wrong
> function.
Oops. Corrected.
> Other than that:
>
> Reviewed-by: Hannes Reinecke <hare@suse.de>
Thanks.
>
> Cheers,
>
> Hannes
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2026-02-19 21:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-19 6:23 [PATCH 0/5] libata cleanups Damien Le Moal
2026-02-19 6:23 ` [PATCH 1/5] ata: libata-core: improve tag checks in ata_qc_issue() Damien Le Moal
2026-02-19 8:19 ` Hannes Reinecke
2026-02-19 6:23 ` [PATCH 2/5] ata: libata-sata: simplify ata_sas_queuecmd() Damien Le Moal
2026-02-19 8:20 ` Hannes Reinecke
2026-02-19 6:23 ` [PATCH 3/5] ata: libata-scsi: simplify ata_scsi_schedule_deferred_qc() Damien Le Moal
2026-02-19 7:52 ` Sergey Shtylyov
2026-02-19 8:21 ` Hannes Reinecke
2026-02-19 21:38 ` Damien Le Moal [this message]
2026-02-19 6:23 ` [PATCH 4/5] ata: libata-scsi: make ata_scsi_simulate() static Damien Le Moal
2026-02-19 8:22 ` Hannes Reinecke
2026-02-19 6:23 ` [PATCH 5/5] ata: libata-scsi: rename and improve ata_qc_done() Damien Le Moal
2026-02-19 8:26 ` Hannes Reinecke
2026-02-24 0:43 ` [PATCH 0/5] libata cleanups Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93cd8b3e-b0ec-46e3-ae38-a29ee63cf3bf@kernel.org \
--to=dlemoal@kernel.org \
--cc=cassel@kernel.org \
--cc=hare@suse.de \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox