* [PATCH] libata-scsi: set correct VERSION field for ZAC devices
@ 2016-07-12 13:45 tom.ty89
2016-07-12 13:58 ` Sergei Shtylyov
0 siblings, 1 reply; 2+ messages in thread
From: tom.ty89 @ 2016-07-12 13:45 UTC (permalink / raw)
To: tj, hare, shaun.tancheff; +Cc: linux-ide, Tom Yan
From: Tom Yan <tom.ty89@gmail.com>
Commit 856c4663930988118d9f355aad66811dd6df06de had the line that
"bumps" the VERSION field in standard INQUIRY data removed. Add
it back and claim SPC-5 version compatibility, which matches with
the current version descriptor "SPC-5 (no version claimed)" used
for ZAC devices.
Signed-off-by: Tom Yan <tom.ty89@gmail.com>
diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index bfec66f..27e29e1 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -2109,8 +2109,10 @@ static unsigned int ata_scsiop_inq_std(struct ata_scsi_args *args, u8 *rbuf)
(args->dev->link->ap->pflags & ATA_PFLAG_EXTERNAL))
hdr[1] |= (1 << 7);
- if (args->dev->class == ATA_DEV_ZAC)
+ if (args->dev->class == ATA_DEV_ZAC) {
hdr[0] = TYPE_ZBC;
+ hdr[2] = 0x7; /* claim SPC-5 version compatibility */
+ }
memcpy(rbuf, hdr, sizeof(hdr));
memcpy(&rbuf[8], "ATA ", 8);
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] libata-scsi: set correct VERSION field for ZAC devices
2016-07-12 13:45 [PATCH] libata-scsi: set correct VERSION field for ZAC devices tom.ty89
@ 2016-07-12 13:58 ` Sergei Shtylyov
0 siblings, 0 replies; 2+ messages in thread
From: Sergei Shtylyov @ 2016-07-12 13:58 UTC (permalink / raw)
To: tom.ty89, tj, hare, shaun.tancheff; +Cc: linux-ide
On 7/12/2016 4:45 PM, tom.ty89@gmail.com wrote:
> From: Tom Yan <tom.ty89@gmail.com>
>
> Commit 856c4663930988118d9f355aad66811dd6df06de had the line that
You also need to specify the commit summary in (""). It's enough to
specify 12 digits of SHA1 ID.
> "bumps" the VERSION field in standard INQUIRY data removed. Add
> it back and claim SPC-5 version compatibility, which matches with
> the current version descriptor "SPC-5 (no version claimed)" used
> for ZAC devices.
>
> Signed-off-by: Tom Yan <tom.ty89@gmail.com>
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-12 13:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-12 13:45 [PATCH] libata-scsi: set correct VERSION field for ZAC devices tom.ty89
2016-07-12 13:58 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).