From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAC11C3DA7D for ; Thu, 5 Jan 2023 03:56:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229481AbjAED4B (ORCPT ); Wed, 4 Jan 2023 22:56:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231682AbjAEDzf (ORCPT ); Wed, 4 Jan 2023 22:55:35 -0500 Received: from esa5.hgst.iphmx.com (esa5.hgst.iphmx.com [216.71.153.144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C74F746802 for ; Wed, 4 Jan 2023 19:54:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1672890874; x=1704426874; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=sJcj1FWMwglYSv5QiOXtM+NnlMSpPPvz2qAzxEE634I=; b=gwB8P+vvZYGVJbZsJQWx4bzY5UW85SESpxnrQkHRzWSyhhdw1SQPGDh0 aep+eXy7v1Oq3jmNDSZv98J5lF8Ih3hdnZDfn/p+of+sVooGx/jJR7Ott IzyYPCf4xLSF5tDMWSdViXv009pJLnZc/qBW1aat+hUxL4ZoiNXKGynBM /rzR7BtbRL/YPzqPzJd1k19+HsPKp2XDwCD/gc1WcKXYhU48G7OQ0EJAS 7A8DBp58gB1Pu3Q9oGs6uN2LkC23gtnefaiDFIAL22QtUcOKjGtWe5z0r L3vOTIN9DOXtWmFQ4W7E/+TXZtJ5xf2Aj72xFLAwJHwwENFbhqGixMTrQ g==; X-IronPort-AV: E=Sophos;i="5.96,301,1665417600"; d="scan'208";a="219944751" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 05 Jan 2023 11:54:34 +0800 IronPort-SDR: 6RD8rG/WgzOt7j3H2CsloHjFJ9FdWw+NT3tjAlKSQuKu1oJ/t/7QYmqf0gOP9RKeRTEfZ9eoOZ 4UTNm4SW6z0UjNMlgF9i1dG3uv0v2bkzjQhMsqpVGht4EPgNTpsPcBW41lcd51EJOT3DdtjCnd LFvjLuAiRAt1QMYzS5wz1KSE1pLQCmWe6zkR7pUCyQ+/ZWDJXEyni2u631TXu0zJj4MjZ8aWn+ 2AGjIJUPOjVWUW95cZv+uaRmh9GmDpJWrT/t5UciLLC76Sao7nnVYiTaVUmS46NzDed2DQtxx4 SaQ= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Jan 2023 19:12:30 -0800 IronPort-SDR: yTbremefBqBcH06o4RNQtfYQByOQaYtEJibDkG+7xD5thfcSt0+nDD49rx9aze2OJKyJaEygka Y2bi4rux+qsCUNcC+ypzJ0VoiZUiMYijOjGKBLSC+wpIdaw95x0FzsDpxy6d9zG4lPRnjEvSog /hZc0y/qFktUyslnYi3yvOjYaYNbe31h/aUW1BRID6uVT9+aKa/L67H8ykbHZuEzwWg+c4/RK+ WXQnmKnSO5C1bnyEOJ2IwVWz8PA6PtfmZ3vPT3S0K2W2u0AZ11j44VPZyvsQBOnZ8C0b1DlsyY KtA= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Jan 2023 19:54:35 -0800 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4NnXfK6PW6z1RwqL for ; Wed, 4 Jan 2023 19:54:33 -0800 (PST) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1672890873; x=1675482874; bh=sJcj1FWMwglYSv5QiOXtM+NnlMSpPPvz2qA zxEE634I=; b=gt8Bv3KCNKzQawY2EQHomLUUCncLi7AIKFX97AOQ4XfnZCawQne fZ/at8b2bJ2e/k9rzyr95kzTYdj6eeysqbTmGdirr5V76uGb4gD9PE7il5lMFpnM IPy5jSpc2oco18XTjrNk81+LKVo2evf1tkySo2pwOKAnsjGo9lMCVfb75WXBENA0 FiZSW+HiB8kbZ2gsChtu0nwrHre872iJkmPdzlqUK6Bg6WUgbYwyEPqEbLa1Lhce h+IvyuLbehnijj+7ZSqaPRBRvOiA6ExRXelOCtqIEuDJIPa8jn0Cd2I0woX51IWT h0ouSlX1Pi0xJxAk90ONGJcRj7H9wGZzxGw== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id QnmsopwPL8XW for ; Wed, 4 Jan 2023 19:54:33 -0800 (PST) Received: from [10.149.53.254] (washi.fujisawa.hgst.com [10.149.53.254]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4NnXfJ1nv7z1RvLy; Wed, 4 Jan 2023 19:54:32 -0800 (PST) Message-ID: <964fb51e-c37e-824f-25bd-ed46d9418a20@opensource.wdc.com> Date: Thu, 5 Jan 2023 12:54:31 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v7 1/7] block: add a sanity check for non-write flush/fua bios Content-Language: en-US To: Ming Lei Cc: linux-ide@vger.kernel.org, linux-block@vger.kernel.org, Jens Axboe , "Maciej S . Szmigiero" , Hannes Reinecke , Christoph Hellwig , Niklas Cassel References: <20230103051924.233796-1-damien.lemoal@opensource.wdc.com> <20230103051924.233796-2-damien.lemoal@opensource.wdc.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On 1/4/23 23:23, Ming Lei wrote: > On Tue, Jan 03, 2023 at 02:19:18PM +0900, Damien Le Moal wrote: >> From: Christoph Hellwig >> >> Check that the PREFUSH and FUA flags are only set on write bios, >> given that the flush state machine expects that. > > flush state machine is only for request based driver, but FUA is > used by bio drivers(dm, md, ...) too, just wondering if bio drivers > are covered for this change? If yes, can you add words in the > commit log? I think they are since it already was the responsibility of dm_submit_bio() and md_submit_bio() to handle PREFLUSH and FUA. > > > Thanks, > Ming > -- Damien Le Moal Western Digital Research