From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 353E0ECAAD3 for ; Sun, 11 Sep 2022 14:18:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229816AbiIKOSt (ORCPT ); Sun, 11 Sep 2022 10:18:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230115AbiIKOSs (ORCPT ); Sun, 11 Sep 2022 10:18:48 -0400 Received: from esa1.hgst.iphmx.com (esa1.hgst.iphmx.com [68.232.141.245]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8207420F7D for ; Sun, 11 Sep 2022 07:18:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1662905927; x=1694441927; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=1ZeosKCdRqJre/8DiboNXUF0h0xy40H1IiMlnXbs1ts=; b=H53/KZpaqqLFIQSYmdfqHo2da5UPUTu3xGRPG6FiT1moPN9U7EbAWjmB JkyoYwqTm8tqv4mDjx9JfNiT+Qi1DGEsngoTXQJMO0SEKN+0pS0NmuCaX dI4b3hF7W9AoTpSOXWaT65cJUea4NzeCmay7+RDWJx9p+gVSgEfy7Vcrr ESgVE02bpWeeuvXl4I0cgRB2uW+09aPbNET1dLUZHRDkka+ibxu1MngSl Fp1GNLSAT1aYplYmyd4A1LxhCbwi/YBIkSj5Jb6hmpuIwi2VUsBBCCLHM 60bukK1vzfnYb0woY2X2shMHY+mylHoqE1Ntsmrj0G1MTJwEvMI6nKBe1 A==; X-IronPort-AV: E=Sophos;i="5.93,307,1654531200"; d="scan'208";a="323164906" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 11 Sep 2022 22:18:46 +0800 IronPort-SDR: E2L3HSmcM737AfRecRwaq7Lz5X07hq3WQ7Ma8AbIV5if4/E/3tY3j7S0de13q1VnNblFzTinyo jTokjX57h1af0KHPBgIRdiwhUMLbcjTyf2Coxcj8mEvXJ1BCf4AfeCB85bkmjMuB2eIM5o+1qs NfeN6zIrDwHRjTmt9GYdcSx/pCDUJGvDtPFOdJHLRXVsA6n8YK7h7rgPygIbhv8BJhNLeL13H7 FV7w+ZQD44bGCP9juy+ZX0AXr03Hn0acx5IxX6CcL2tW+jJYUp0QjnoYxZlUNHQIXWzOFDomgx IbJZGNQz5vyXLjCGitYGNO8F Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 Sep 2022 06:33:37 -0700 IronPort-SDR: tNSu2oxPOLmdEoZKIHDXyJ37ly+Dz0AR6k3ySRlRUjUJqh59IOVr4jWinj6CyiJQRbVw2NEW0s RKEiqCGnpEbKVSWKqgqKviw+GXZB5aV2PCPB+n3JiSZ8f6ehJ+8Gs0OdgMaGZPMQQP8sxo5shq ns9iTqhTgepl4xHR0pj7rSx8KSbzgidXM7cJ8Mh6//sZzbsn9qtA02uykK/YR9dsSZ24Tj3C97 xuChumbKpPtTpTLpYaJaOsxxI8O64XZ8tJTKZzM0h/aBnlKUUtxx4PBiNxMRrZYqXqVj5IYU1E Pg0= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 Sep 2022 07:18:46 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4MQX0637pWz1RvTp for ; Sun, 11 Sep 2022 07:18:46 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1662905925; x=1665497926; bh=1ZeosKCdRqJre/8DiboNXUF0h0xy40H1IiM lnXbs1ts=; b=j4h2ZE/9PX6h/2kYKLziwwoSgdmonXasjWQwvwVH6ACmLFoeoQC RIAi/oynNfqjDavUA/A9ZlQSaIU2wt6G7N+Z5LeY0j6WKkCIQEexOpArbHZcK7rz 608Gw/tG/qm0KYRDg3nUrrcfMhvhif7729OMuAtTtXRmcRCPBX1eOw6PVAZdXj26 gTwhvg7Z0Zmm3wyLcqoAHrL2j9S1ZRcP/v5z3Ha2/05VGkPZA11LtjpPoZPaY63A pD8vGUpLde2i8Xeu3yNpleGpo4howJ9GIfSdaSoruNfpKDdhzsGhkW+hIdnuibbG 6dB1jAdwiBHJNCV4FGuKPh40dmLBeCSQyTQ== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id SGnDfYS0hc-m for ; Sun, 11 Sep 2022 07:18:45 -0700 (PDT) Received: from [10.225.1.43] (unknown [10.225.1.43]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4MQX024lcsz1RvLy; Sun, 11 Sep 2022 07:18:42 -0700 (PDT) Message-ID: <99d7c533-f19e-a52a-e532-2a07cd78e9b9@opensource.wdc.com> Date: Sun, 11 Sep 2022 23:18:40 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2] powerpc: select HAVE_PATA_PLATFORM in PPC instead of creating a PPC dependency Content-Language: en-US To: Arnd Bergmann , Christophe Leroy , Lukas Bulwahn , Michael Ellerman , Nicholas Piggin , "linuxppc-dev@lists.ozlabs.org" , "linux-ide@vger.kernel.org" Cc: "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20220909090343.21886-1-lukas.bulwahn@gmail.com> <21359abe-c3c9-4aa8-8ebf-75ff64cb1935@www.fastmail.com> <2379456e-4f18-d619-10bf-022327de0463@csgroup.eu> <4b33bffc-2b6d-46b4-9f1d-d18e55975a5a@www.fastmail.com> <0ad5f339-de31-2849-34a1-928ae65cc696@opensource.wdc.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On 2022/09/11 21:41, Arnd Bergmann wrote: > On Sun, Sep 11, 2022, at 1:54 PM, Damien Le Moal wrote: >> On 2022/09/09 20:31, Arnd Bergmann wrote: >>> >>> config PATA_PLATFORM >>> - tristate "Generic platform device PATA support" >>> - depends on EXPERT || PPC || HAVE_PATA_PLATFORM >>> + tristate "Generic platform device PATA support" if EXPERT || HAVE_PATA_PLATFORM >> >> Shouldn't this be: >> >> tristate "Generic platform device PATA support" if EXPERT || PPC >> >> ? >> >> And while at it, it would be nice to add "|| COMPILE_TEST" too. > > The idea was that this can be selected by CONFIG_PATA_OF_PLATFORM > in any configuration that has CONFIG_OF enabled. Since PPC > has CONFIG_OF enabled unconditionally, there is no need to > make this option visible separately. > > Same for compile-testing: since CONFIG_OF can be enabled on > any architecture, PATA_OF_PLATFORM is already covered by > allmodconfig builds anywhere. The separate HAVE_PATA_PLATFORM > is only needed for machines that want the non-OF pata-platform > module (sh, m68k-mac, mips-sibyte arm-s3c-simtec). Got it. Thanks for the details. > > Arnd -- Damien Le Moal Western Digital Research