From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03B1CC61DA4 for ; Wed, 15 Mar 2023 23:58:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232817AbjCOX6s (ORCPT ); Wed, 15 Mar 2023 19:58:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232278AbjCOX6m (ORCPT ); Wed, 15 Mar 2023 19:58:42 -0400 Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5800F6B322 for ; Wed, 15 Mar 2023 16:58:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1678924703; x=1710460703; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Kgkn81sm7NRXOWlx9WugG0VfUhPksFZvAliPQZFpRVQ=; b=irZTTlfAzmyu1U1UjAASkVqcVBv6rCvMBnyH3lBfOXCbafuLdHKrrMK7 PF95wZbRc+KTPqwrxBb3Wx94dLcqYG/0aQqBX4BghZm9cLB1mPtjDq6TP McXFrENTm38/9t2BeXb0whEEnnPkuUwt/vO3uQUkoJhdO7WZRBDFhMYAk YIXSZnZdfKS2B9pA4YkXqZEYVjUXhZ3eb7xZb/FjIUTGPQ7MzeekkGbiN 4kx2uJZQ5QmDe3ASKQR5TUZ6+FF8FtVRZMUucvvRKN2e6gTuLQ91PnEwo aU/TGuFJfFu5kbZ2wP7enCj9tNY8NB26WUwFk0FqGfzH6PhxYaZIZz+ul g==; X-IronPort-AV: E=Sophos;i="5.98,262,1673884800"; d="scan'208";a="230684078" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 16 Mar 2023 07:57:46 +0800 IronPort-SDR: MCEcsAzghNY71ZS+ue5yMaZ5+/jdidLkxHzcOn6c6xfgRayOsSg699hbH/7tGkTLGy4L+gxVnS gYoCmrXo6FRiEjZGP0oTemuuSButRs7sifoTwr7MeVCn/RrwAIgAfhv1RoUIzaRfmCQYrLb+Uj VZ0pIlGaDHu+uSSojzD/zoCazh1rtauK/bGioaFQWR6E7LHmqj0MMCsd5O+1zR35xGYOh5dI+D lGJHRevLymQi356F715WaF6zkSrH1HwV1u7q8rfRvdi/3/FPhf4gEuM+iZqTsPrnmf7nExCysw H9w= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Mar 2023 16:14:12 -0700 IronPort-SDR: u1XL7I/57vJnYjCA+vowJDlWoiHmsFGwvcq6TEluVVMOCtwtWpPOI/58RnUY9gcBvu43CdVXAp K8xTUGl2tKDuCf4LBzx5dCuXvEgllZVW8t0uBP16vkUDRfu0M/FkKgmsIS3dZ6gBjIHUy8fWtM TQXivrW873JlOQjC1TL918NUjvF5xKXB1dwzuYp+FQR/QaX5hXign7zZKhV6TE9IwcLREL9U8Y Wo/w8w0RJAkJKz6+fLs0PqWLlH4mm/kWsxsykLhYVxSyM8eAOe8FTIkh8ioE2IbUZX9KAV+TZ5 VEo= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Mar 2023 16:57:47 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4PcS4n6FPcz1RtVy for ; Wed, 15 Mar 2023 16:57:45 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1678924664; x=1681516665; bh=Kgkn81sm7NRXOWlx9WugG0VfUhPksFZvAli PQZFpRVQ=; b=IJtu4gmgw/ynZRHEPjr86PzZEB+9IZ6sFhO3BWek4topABF4AL6 v3GWhfKBe54UfpGLOFp+QZ0207SarBzrk31qIPDeSsCcTa1sVE9ZQ2bmJGtFKrQD FTxO22grvCPJxXI7W2DeuOYT8tAJsT0Ehs3tnsW/CNixYYLG4uGJQYpmZPWIICSm jZ/bMPo0r6g5G1+7XnM0IvrxSu5M39QdCyQrQKQ7lNJQd6/WQ/pI30xDh1byrzFN HtEWyRNwRo0z0eh3wHvYGoB+TqsYLrPr0WwsolzG75dRQ5uqCaymbGeWw1+QmoEM kajt4jFnk5yN3q/hsvMJwI3BTonbXZ3jdig== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id uTFVsWd4C15C for ; Wed, 15 Mar 2023 16:57:44 -0700 (PDT) Received: from [10.89.80.69] (c02drav6md6t.dhcp.fujisawa.hgst.com [10.89.80.69]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4PcS4k216nz1RtVm; Wed, 15 Mar 2023 16:57:42 -0700 (PDT) Message-ID: <9a1c49b0-2271-53c7-7f48-039f83d39e82@opensource.wdc.com> Date: Thu, 16 Mar 2023 08:57:40 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 02/38] ata: add HAS_IOPORT dependencies Content-Language: en-US To: Geert Uytterhoeven Cc: Niklas Schnelle , Arnd Bergmann , Greg Kroah-Hartman , Bjorn Helgaas , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Mauro Carvalho Chehab , Alan Stern , "Rafael J. Wysocki" , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-pci@vger.kernel.org, Arnd Bergmann , linux-ide@vger.kernel.org References: <20230314121216.413434-1-schnelle@linux.ibm.com> <20230314121216.413434-3-schnelle@linux.ibm.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On 2023/03/15 20:36, Geert Uytterhoeven wrote: > Hi Damien, >=20 > On Wed, Mar 15, 2023 at 10:12=E2=80=AFAM Damien Le Moal > wrote: >> On 3/15/23 17:39, Geert Uytterhoeven wrote: >>> On Tue, Mar 14, 2023 at 1:12=E2=80=AFPM Niklas Schnelle wrote: >>>> In a future patch HAS_IOPORT=3Dn will result in inb()/outb() and fri= ends >>>> not being declared. We thus need to add HAS_IOPORT as dependency for >>>> those drivers using them. >>>> >>>> Co-developed-by: Arnd Bergmann >>>> Signed-off-by: Niklas Schnelle >>> >>> Thanks for your patch! >>> >>>> --- a/drivers/ata/Kconfig >>>> +++ b/drivers/ata/Kconfig >>>> @@ -342,6 +342,7 @@ endif # HAS_DMA >>>> >>>> config ATA_SFF >>>> bool "ATA SFF support (for legacy IDE and PATA)" >>>> + depends on HAS_IOPORT >>>> default y >>>> help >>>> This option adds support for ATA controllers with SFF >>> >>> ATA_SFF is a dependency for lots of (S)ATA drivers. >>> (at least) The following don't use I/O port access: >>> >>> CONFIG_SATA_RCAR (arm/arm64) >>> CONFIG_PATA_FALCON (m68k/atari and m68k/q40) >>> CONFIG_PATA_GAYLE (m68k/amiga) >>> CONFIG_PATA_BUDDHA (m68k/amiga) >>> >>> (at least) The following can use either MMIO or I/O port accesses: >>> >>> CONFIG_PATA_PLATFORM (m68k/mac) >> >> But for these arch/platforms, would there be any reason to not have HA= S_IOPORT ? >> It is supported right now, so we should have HAS_IOPORT for them. >=20 > That's the point: on Amiga and Atari, HAS_IOPORT is optional, and > not related to IDE support. On Mac, it is never present. Ah. OK. I see now. So indeed, applying the dependency on the entire ATA_S= FF group of drivers is very coarse. Niklas, Can you change this to apply the dependency per driver ? --=20 Damien Le Moal Western Digital Research