From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>,
<linux-ide@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] ata: libata-sff: refactor ata_sff_set_devctl()
Date: Mon, 14 Feb 2022 11:37:11 +0300 [thread overview]
Message-ID: <9bd9671f-e990-3ebe-a8d8-a3683ef58eeb@omp.ru> (raw)
In-Reply-To: <82f8b8fd-56c8-b6ed-9658-822643e0e0c9@opensource.wdc.com>
On 2/14/22 2:25 AM, Damien Le Moal wrote:
>> Commit 41dec29bcb05 ("libata: introduce sff_set_devctl() method") left some
>> clumsy checks surrounding calls to ata_sff_set_devctl() which Jeff Garzik
>> suggested to factor out... and I never followed up. :-(
>>
>> At last, refactor ata_sff_set_devctl() to include the repetitive checks and
>> return a 'bool' result indicating if the device control register exists or
>> not.
>>
>> While at it, further update the 'kernel-doc' comment -- the device control
>> register has never been a part of the taskfile, despite what Jeff and co.
>> think! :-)
>>
>> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>
> This patch has "v2"... I do not recall seeing a v1 and the cover letter has no
> changelog (and no v2 tag)... Is this a new series ?
That v2 is there by mistake, please ignore it.
[...]
MBR, Sergey
next prev parent reply other threads:[~2022-02-14 8:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-13 15:10 [PATCH 0/2] Refactor the accessors for the ATA device control and alternate status registers Sergey Shtylyov
2022-02-13 15:10 ` [PATCH v2 1/2] ata: libata-sff: refactor ata_sff_set_devctl() Sergey Shtylyov
2022-02-13 23:25 ` Damien Le Moal
2022-02-14 8:37 ` Sergey Shtylyov [this message]
2022-02-13 15:10 ` [PATCH v2 2/2] ata: libata-sff: refactor ata_sff_altstatus() Sergey Shtylyov
2022-02-17 12:12 ` Dan Carpenter
2022-02-17 16:02 ` Sergey Shtylyov
2022-02-18 22:58 ` Damien Le Moal
2022-02-18 22:59 ` Damien Le Moal
2022-02-16 7:20 ` [PATCH 0/2] Refactor the accessors for the ATA device control and alternate status registers Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bd9671f-e990-3ebe-a8d8-a3683ef58eeb@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=damien.lemoal@opensource.wdc.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox