From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Tejun Heo <htejun@gmail.com>, Jeff Garzik <jeff@garzik.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] pata_legacy: fix a couple uninitialized variable bugs
Date: Tue, 12 Oct 2021 09:54:49 +0900 [thread overview]
Message-ID: <9dc07497-050d-1562-70bc-68daa460da67@opensource.wdc.com> (raw)
In-Reply-To: <20211006073419.GC8404@kili>
On 10/6/21 16:34, Dan Carpenter wrote:
> The last byte of "pad" is used without being initialized.
>
> Fixes: 55dba3120fbc ("libata: update ->data_xfer hook for ATAPI")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/ata/pata_legacy.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ata/pata_legacy.c b/drivers/ata/pata_legacy.c
> index c3e6592712c4..b53f0e09783d 100644
> --- a/drivers/ata/pata_legacy.c
> +++ b/drivers/ata/pata_legacy.c
> @@ -352,7 +352,7 @@ static unsigned int pdc_data_xfer_vlb(struct ata_queued_cmd *qc,
> iowrite32_rep(ap->ioaddr.data_addr, buf, buflen >> 2);
>
> if (unlikely(slop)) {
> - __le32 pad;
> + __le32 pad = 0;
> if (rw == READ) {
> pad = cpu_to_le32(ioread32(ap->ioaddr.data_addr));
> memcpy(buf + buflen - slop, &pad, slop);
> @@ -742,7 +742,7 @@ static unsigned int vlb32_data_xfer(struct ata_queued_cmd *qc,
> ioread32_rep(ap->ioaddr.data_addr, buf, buflen >> 2);
>
> if (unlikely(slop)) {
> - __le32 pad;
> + __le32 pad = 0;
> if (rw == WRITE) {
> memcpy(&pad, buf + buflen - slop, slop);
> iowrite32(le32_to_cpu(pad), ap->ioaddr.data_addr);
>
Applied to for-5.15-fixes. Thanks !
(Note: I added a blank line after the pad declaration to follow kernel
style).
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2021-10-12 0:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 7:34 [PATCH] pata_legacy: fix a couple uninitialized variable bugs Dan Carpenter
2021-10-12 0:54 ` Damien Le Moal [this message]
2021-10-12 6:36 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9dc07497-050d-1562-70bc-68daa460da67@opensource.wdc.com \
--to=damien.lemoal@opensource.wdc.com \
--cc=dan.carpenter@oracle.com \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox