From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Boris Petkov" Subject: Re: New CD/DVD reports 'Can Play Audio NO' Date: Tue, 14 Oct 2008 11:03:01 +0200 Message-ID: <9ea470500810140203l56cbc1d3i9a798580efe91867@mail.gmail.com> References: <20081004103355.407fc303@sauron.linicks.net> <48E82FDB.6020009@kernel.org> <20081005120809.38eb4826@sauron.linicks.net> <48F441F0.90408@kernel.org> <9ea470500810140126v3058d99dn47768834bd087111@mail.gmail.com> <48F45D70.7000904@kernel.org> Reply-To: petkovbb@gmail.com Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from rn-out-0910.google.com ([64.233.170.187]:1326 "EHLO rn-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753672AbYJNJDF (ORCPT ); Tue, 14 Oct 2008 05:03:05 -0400 Received: by rn-out-0910.google.com with SMTP id k40so981343rnd.17 for ; Tue, 14 Oct 2008 02:03:01 -0700 (PDT) In-Reply-To: <48F45D70.7000904@kernel.org> Content-Disposition: inline Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: Nick Warne , linux-kernel@vger.kernel.org, D Bray , IDE/ATA development list , Bartlomiej Zolnierkiewicz [..] >>> Thanks. sr.c just doesn't check whether the drive reports audio play >>> capability or not. It just sets it while ide-cd actually checks for >>> the capability. The drive is not reporting it while it can so ide-cd >>> needs blacklist entry for it. Now that idecd has blacklist entry, all >>> should be fine. Eh... I'm not sure whether we need to update sr to >>> follow what ide-cd is doing or not. >>> >>> Thanks. >> >> Actually, as I already pointed out, I'm not at all happy with blacklisting >> stuff. What sounds more sane to me (and this is only me) would be what sr.c >> does: assume that per se the drive can play audio and try to play it. But how >> many drives are there that cannot play audio, aka, would it be a safe assumption >> to say that their number is so diminishingly small that it would be better to >> announce that a drive can play audio by default and fail graciously in the >> _very_ seldom case it actually cannot ... >> > > Hmm... I don't know. I think the flag indicates whether the drive has > DAC and analog audio output, right? Currently, ide-cd checks the AudioPlay bit advertized in the CD-ROM Capabilities and Mechanical Status Page. > I have quite some SATA drives which > don't have audio output at all. I haven't check what they report on the > mode sense page yet. Eh... well, having the bit set when the drive > doesn't support it doesn't hurt too much (yet). Bartlomiej, what do you > think? -- Regards/Gruss, Boris