From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kumar Gala Subject: Re: [PATCH] ata_piix: Fix build breakage Date: Wed, 28 Jan 2009 00:08:39 -0600 Message-ID: References: <1233118922-15350-1-git-send-email-galak@kernel.crashing.org> <1233118922-15350-2-git-send-email-galak@kernel.crashing.org> Mime-Version: 1.0 (Apple Message framework v929.2) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from gate.crashing.org ([63.228.1.57]:46020 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751155AbZA1HJT (ORCPT ); Wed, 28 Jan 2009 02:09:19 -0500 In-Reply-To: <1233118922-15350-2-git-send-email-galak@kernel.crashing.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Kumar Gala Cc: jeff@garzik.org, Linus Torvalds , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, rjw@sisk.pl On Jan 27, 2009, at 11:02 PM, Kumar Gala wrote: > The following commit introduces: > > commit 5f451fe1ab5d73b987051f0d23c85216c552e163 > Author: Rafael J. Wysocki > Date: Mon Jan 19 20:59:22 2009 +0100 > > SATA PIIX: Blacklist system that spins off disks during ACPI > power off > > the following build errors on non-x86 systems: > > drivers/ata/ata_piix.c: In function 'piix_broken_system_poweroff': > drivers/ata/ata_piix.c:1405: error: implicit declaration of function > 'dmi_first_match' > drivers/ata/ata_piix.c:1405: warning: initialization makes pointer > from integer without a cast > > Signed-off-by: Kumar Gala > --- > drivers/ata/ata_piix.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) it was pointed out that fixing include/linux/dmi.h was the better way to fix this. I've posted a patch for fixing dmi.h that supersedes this patch. - k