From: raymond pang <raymondpangxd@gmail.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: fix using DMA buffers on stack
Date: Thu, 28 Mar 2019 12:00:15 +0000 [thread overview]
Message-ID: <CAHG4imPE3pNXAd5WvF-7hLyyZfpgAcT7KkVoCa+0iTGbHxxbvA@mail.gmail.com> (raw)
In-Reply-To: <742c1607-1e28-3674-65ca-8e5f111e243e@kernel.dk>
hi Jens,
Thanks for review. I'll fix them up.
Best regards,
Raymond
On Tue, Mar 26, 2019 at 2:09 PM Jens Axboe <axboe@kernel.dk> wrote:
>
> On 3/25/19 9:07 PM, raymond pang wrote:
> > When CONFIG_VMAP_STACK=y, __pa() returns incorrect physical address for
> > a stack virtual address. Stack DMA buffers must be avoided.
>
> The patch looks fine, but it's white space mangled so it won't apply.
> Additionally, you don't need to use kzfree, just use kfree.
>
> --
> Jens Axboe
>
next prev parent reply other threads:[~2019-03-28 12:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 3:07 [PATCH] libata: fix using DMA buffers on stack raymond pang
2019-03-26 14:09 ` Jens Axboe
2019-03-28 12:00 ` raymond pang [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-03-28 12:19 raymond pang
2019-03-28 14:17 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHG4imPE3pNXAd5WvF-7hLyyZfpgAcT7KkVoCa+0iTGbHxxbvA@mail.gmail.com \
--to=raymondpangxd@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).