From: Timur Tabi <timur@tabi.org>
To: Mark Langsdorf <mark.langsdorf@calxeda.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
linux-ide@vger.kernel.org, Jeff Garzik <jgarzik@pobox.com>
Subject: Re: [PATCH] ata: increase retry count but shorten duration for Calxeda controller
Date: Mon, 6 May 2013 10:45:45 -0500 [thread overview]
Message-ID: <CAOZdJXWBQGjs_eLJ_jdrcp5DYaPgFr50_ZF-eCHzPPMvHYgD-Q@mail.gmail.com> (raw)
In-Reply-To: <1367444087-18336-1-git-send-email-mark.langsdorf@calxeda.com>
On Wed, May 1, 2013 at 4:34 PM, Mark Langsdorf
<mark.langsdorf@calxeda.com> wrote:
>
> - const unsigned long *timing = sata_ehc_deb_timing(&link->eh_context);
> + unsigned long timing[] = { 5, 100, 500};
Why are you dropping the 'const'?
Assuming it works, this should be more efficient:
static const unsigned long timing[] = {5, 100, 500};
next prev parent reply other threads:[~2013-05-06 15:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-01 21:34 [PATCH] ata: increase retry count but shorten duration for Calxeda controller Mark Langsdorf
2013-05-06 15:45 ` Timur Tabi [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-05-29 15:51 Mark Langsdorf
2013-05-29 20:12 ` Timur Tabi
2013-05-29 20:35 ` Mark Langsdorf
2013-05-30 6:58 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOZdJXWBQGjs_eLJ_jdrcp5DYaPgFr50_ZF-eCHzPPMvHYgD-Q@mail.gmail.com \
--to=timur@tabi.org \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.langsdorf@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).