linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch 3/4]  ide/ide-cd: replace  cdrom_sleep() with msleep()
@ 2004-10-21  8:41 janitor
  0 siblings, 0 replies; only message in thread
From: janitor @ 2004-10-21  8:41 UTC (permalink / raw)
  To: B.Zolnierkiewicz; +Cc: linux-ide, janitor, nacc




Any comments would be appreciated.

Description: Uses msleep() in place of cdrom_sleep()
to guarantee the task delays as expected.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>

---

 linux-2.6.9-max/drivers/ide/ide-cd.c |   15 +--------------
 1 files changed, 1 insertion(+), 14 deletions(-)

diff -puN drivers/ide/ide-cd.c~msleep-drivers_ide_ide-cd drivers/ide/ide-cd.c
--- linux-2.6.9/drivers/ide/ide-cd.c~msleep-drivers_ide_ide-cd	2004-10-21 02:37:56.000000000 +0200
+++ linux-2.6.9-max/drivers/ide/ide-cd.c	2004-10-21 02:37:56.000000000 +0200
@@ -1514,19 +1514,6 @@ static ide_startstop_t cdrom_do_packet_c
 }
 
 
-/* Sleep for TIME jiffies.
-   Not to be called from an interrupt handler. */
-static
-void cdrom_sleep (int time)
-{
-	int sleep = time;
-
-	do {
-		set_current_state(TASK_INTERRUPTIBLE);
-		sleep = schedule_timeout(sleep);
-	} while (sleep);
-}
-
 static
 int cdrom_queue_packet_command(ide_drive_t *drive, struct request *rq)
 {
@@ -1561,7 +1548,7 @@ int cdrom_queue_packet_command(ide_drive
 				/* The drive is in the process of loading
 				   a disk.  Retry, but wait a little to give
 				   the drive time to complete the load. */
-				cdrom_sleep(2 * HZ);
+				msleep(2000);
 			} else {
 				/* Otherwise, don't retry. */
 				retries = 0;
_

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-10-21  8:41 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-21  8:41 [patch 3/4] ide/ide-cd: replace cdrom_sleep() with msleep() janitor

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).