From: Roman Zippel <zippel@linux-m68k.org>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org,
jens.axboe@oracle.com, tsbogend@alpha.franken.de,
bzolnier@gmail.com, petkovbb@gmail.com, jeff@garzik.org,
davem@davemloft.net, akpm@linux-foundation.org,
linux-arch@vger.kernel.org
Subject: Re: [PATCH v2 -mm 4/6] ide: avoid DMA on the stack for REQ_TYPE_ATA_PC
Date: Mon, 9 Jun 2008 19:44:56 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0806091937580.6791@localhost.localdomain> (raw)
In-Reply-To: <1212682248.13549.48.camel@localhost.localdomain>
Hi,
On Thu, 5 Jun 2008, James Bottomley wrote:
> I'm also not keen on the use of current->stack. It looks like this
> commit:
>
> commit f7e4217b007d1f73e7e3cf10ba4fea4a608c603f
> Author: Roman Zippel <zippel@linux-m68k.org>
> Date: Wed May 9 02:35:17 2007 -0700
>
> rename thread_info to stack
>
> Introduced a task_stack_page() accessor to get this instead, so perhaps
> we should use it (I've cc'd Roman and linux-arch for opinions).
This helper was mainly introduced to help with the transition from direct
thread_info access. I don't see this field go away or change somehow in
the near future, so direct access of stack is IMO ok, but we already have
the helper, so using it to improve readability is fine too.
bye, Roman
prev parent reply other threads:[~2008-06-09 17:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-02 6:57 [PATCH v2 -mm 0/6] revert the commit 22a9189f (cdrom: use kmalloced buffers instead of buffers on stack) FUJITA Tomonori
2008-06-02 6:57 ` [PATCH v2 -mm 1/6] block: add blk_queue_update_dma_pad FUJITA Tomonori
2008-06-02 6:57 ` [PATCH v2 -mm 2/6] ide: use the dma safe check for REQ_TYPE_ATA_PC FUJITA Tomonori
2008-06-02 6:57 ` [PATCH v2 -mm 3/6] block: blk_rq_map_kern uses the bounce buffers for stack buffers FUJITA Tomonori
2008-06-02 6:57 ` [PATCH v2 -mm 4/6] ide: avoid DMA on the stack for REQ_TYPE_ATA_PC FUJITA Tomonori
2008-06-02 6:57 ` [PATCH v2 -mm 5/6] scsi: sr avoids useless buffer allocation FUJITA Tomonori
2008-06-02 6:57 ` [PATCH v2 -mm 6/6] cdrom: revert commit 22a9189 (cdrom: use kmalloced buffers instead of buffers on stack) FUJITA Tomonori
2008-06-02 19:14 ` [PATCH v2 -mm 4/6] ide: avoid DMA on the stack for REQ_TYPE_ATA_PC Borislav Petkov
2008-06-05 16:10 ` James Bottomley
2008-06-05 19:14 ` Borislav Petkov
2008-06-07 4:45 ` FUJITA Tomonori
2008-06-09 17:44 ` Roman Zippel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0806091937580.6791@localhost.localdomain \
--to=zippel@linux-m68k.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=bzolnier@gmail.com \
--cc=davem@davemloft.net \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=jeff@garzik.org \
--cc=jens.axboe@oracle.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=petkovbb@gmail.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox