From: Niklas Cassel <Niklas.Cassel@wdc.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Damien Le Moal <damien.lemoal@opensource.wdc.com>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: Re: [PATCH] ata: octeon: Drop empty platform remove function
Date: Fri, 30 Dec 2022 07:00:17 +0000 [thread overview]
Message-ID: <Y66MgAnHgvyv1N8b@x1-carbon> (raw)
In-Reply-To: <20221212214112.3775327-1-u.kleine-koenig@pengutronix.de>
On Mon, Dec 12, 2022 at 10:41:12PM +0100, Uwe Kleine-König wrote:
> A remove callback just returning 0 is equivalent to no remove callback
> at all. So drop the useless function.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/ata/ahci_octeon.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/ata/ahci_octeon.c b/drivers/ata/ahci_octeon.c
> index b9460b91288f..5021ab3ede49 100644
> --- a/drivers/ata/ahci_octeon.c
> +++ b/drivers/ata/ahci_octeon.c
> @@ -73,11 +73,6 @@ static int ahci_octeon_probe(struct platform_device *pdev)
> return 0;
> }
>
> -static int ahci_octeon_remove(struct platform_device *pdev)
> -{
> - return 0;
> -}
> -
> static const struct of_device_id octeon_ahci_match[] = {
> { .compatible = "cavium,octeon-7130-sata-uctl", },
> { /* sentinel */ }
> @@ -86,7 +81,6 @@ MODULE_DEVICE_TABLE(of, octeon_ahci_match);
>
> static struct platform_driver ahci_octeon_driver = {
> .probe = ahci_octeon_probe,
> - .remove = ahci_octeon_remove,
> .driver = {
> .name = "octeon-ahci",
> .of_match_table = octeon_ahci_match,
>
> base-commit: 830b3c68c1fb1e9176028d02ef86f3cf76aa2476
> --
> 2.38.1
>
Reviewed-by: Niklas Cassel <niklas.cassel@wdc.com>
next prev parent reply other threads:[~2022-12-30 7:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 21:41 [PATCH] ata: octeon: Drop empty platform remove function Uwe Kleine-König
2022-12-30 7:00 ` Niklas Cassel [this message]
2023-01-02 23:40 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y66MgAnHgvyv1N8b@x1-carbon \
--to=niklas.cassel@wdc.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=kernel@pengutronix.de \
--cc=linux-ide@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox