Re: [PATCH v6 6/7] ata: libata: blacklist FUA support for known buggy drives

Niklas Cassel
2022-12-30T08:58:35Z

On Tue, Nov 08, 2022 at 02:55:43PM +0900, Damien Le Moal wrote:
> Thread [1] reported back in 2012 problems with enabling FUA for 3
> different drives. Add these drives to ata_device_blacklist[] to mark
> them with the ATA_HORKAGE_NO_FUA flag. To be conservative and avoid
> problems on old systems, the model number for the three new entries
> are defined as to widely match all drives in the same product line.
>
> [1]: https://lore.kernel.org/lkml/CA+6av4=uxu_q5U_46HtpUt=FSgbh3pZuAEY54J5_xK=MKWq-YQ@mail.gmail.com/
>
> Suggested-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> Reviewed-by: Hannes Reinecke <hare@suse.de>
> Reviewed-by: Maciej S. Szmigiero <maciej.szmigiero@oracle.com>
> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/ata/libata-core.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 2b66fe529d81..97ade977b830 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4133,6 +4133,9 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
>
> /* Buggy FUA */
> { "Maxtor", "BANC1G10", ATA_HORKAGE_NO_FUA },
> + { "WDC*WD2500J*", NULL, ATA_HORKAGE_NO_FUA },
> + { "OCZ-VERTEX*", NULL, ATA_HORKAGE_NO_FUA },
> + { "INTEL*SSDSC2CT*", NULL, ATA_HORKAGE_NO_FUA },
>
> /* End Marker */
> { }
> --
> 2.38.1
>

Reviewed-by: Niklas Cassel <niklas.cassel@wdc.com>