Re: [PATCH v3 04/18] scsi: rename and move get_scsi_ml_byte()

Bart Van Assche
2023-01-24T19:34:13Z

On 1/24/23 11:02, Niklas Cassel wrote:
> SCSI has two different getters:
> - get_XXX_byte() (in scsi_cmnd.h) which takes a struct scsi_cmnd *, and
> - XXX_byte() (in scsi.h) which takes a scmd->result.
> The proper name for get_scsi_ml_byte() should thus be without the get_
> prefix, as it takes a scmd->result. Rename the function to rectify this.
> (This change was suggested by Mike Christie.)
>
> Additionally, move get_scsi_ml_byte() to scsi_priv.h since both scsi_lib.c
> and scsi_error.c will need to use this helper in a follow-up patch.

Reviewed-by: Bart Van Assche <bvanassche@acm.org>