Re: [PATCH v3 14/18] ata: libata-scsi: add support for CDL pages mode sense

Hannes Reinecke
2023-01-27T15:38:48Z

On 1/24/23 20:03, Niklas Cassel wrote:
> From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
>
> Modify ata_scsiop_mode_sense() and ata_msense_control() to support mode
> sense access to the T2A and T2B sub-pages of the control mode page.
> ata_msense_control() is modified to support sub-pages. The T2A sub-page
> is generated using the read descriptors of the command duration limits
> log page 18h. The T2B sub-page is generated using the write descriptors
> of the same log page. With the addition of these sub-pages, getting all
> sub-pages of the control mode page is also supported by increasing the
> value of ATA_SCSI_RBUF_SIZE from 576B up to 2048B to ensure that all
> sub-pages fit in the fill buffer.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> Co-developed-by: Niklas Cassel <niklas.cassel@wdc.com>
> Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
> ---
> drivers/ata/libata-scsi.c | 150 ++++++++++++++++++++++++++++++++------
> 1 file changed, 128 insertions(+), 22 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes