Re: [PATCH v3 13/18] ata: libata-scsi: handle CDL bits in ata_scsiop_maint_in()

Hannes Reinecke
2023-01-27T15:37:37Z

On 1/24/23 20:02, Niklas Cassel wrote:
> From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
>
> For a scsi MAINTENANCE_IN/MI_REPORT_SUPPORTED_OPERATION_CODES operation,
> add the translation of the rwcdlp and cdlp bits for the READ16 and
> WRITE16 commands. If the ATA device does not support command duration
> limits, these bits are always 0. If the ATA device supports command
> duration limits, the rwcdlp bit is set to 1 for READ16 and WRITE16 and
> the cdlp bits are set to 0x1 for READ16 and 0x2 for WRITE16. These
> correspond to the T2A mode page containing the read descriptors and
> to the T2B mode page containing the write descriptors, as defined in
> SAT-5.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
> ---
> drivers/ata/libata-scsi.c | 30 ++++++++++++++++++++++++++----
> 1 file changed, 26 insertions(+), 4 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes