Re: [PATCH v2] ata: pata_marvell: Check the 'bmdma_addr' beforing reading

Zheyu Ma
2022-04-22T01:50:48Z

On Fri, Apr 22, 2022 at 7:48 AM Damien Le Moal
<damien.lemoal@opensource.wdc.com> wrote:
>
> On 4/21/22 10:39, Zheyu Ma wrote:
> > Before detecting the cable type on the dma bar, the driver should check
> > whether the 'bmdma_addr' is zero, which means the adapter does not
> > support DMA, otherwise we will get the following error:
> >
> > [ 5.146634] Bad IO access at port 0x1 (return inb(port))
> > [ 5.147206] WARNING: CPU: 2 PID: 303 at lib/iomap.c:44 ioread8+0x4a/0x60
> > [ 5.150856] RIP: 0010:ioread8+0x4a/0x60
> > [ 5.160238] Call Trace:
> > [ 5.160470] <TASK>
> > [ 5.160674] marvell_cable_detect+0x6e/0xc0 [pata_marvell]
> > [ 5.161728] ata_eh_recover+0x3520/0x6cc0
> > [ 5.168075] ata_do_eh+0x49/0x3c0
> >
> > Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
> > ---Changes in v2:
> > - Delete the useless 'else'
>
> Note for future contributions: The change log should be placed *after*
> the "---" that comes before the "diff" line below. Otherwise, the change
> log pollutes the commit message.

Thank you for the reminder, I'll pay attention to this problem next time!

Zheyu Ma