From: Niklas Cassel <Niklas.Cassel@wdc.com>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
Sergey Shtylyov <s.shtylyov@omp.ru>
Subject: Re: [PATCH] ata: libata-core: Simplify ata_build_rw_tf()
Date: Wed, 31 Aug 2022 11:33:21 +0000 [thread overview]
Message-ID: <Yw9HABQ398eis3Mk@x1-carbon> (raw)
In-Reply-To: <20220825223853.354968-1-damien.lemoal@opensource.wdc.com>
On Fri, Aug 26, 2022 at 07:38:53AM +0900, Damien Le Moal wrote:
> Since ata_build_rw_tf() is only called from ata_scsi_rw_xlat() with the
> tf, dev and tag arguments obtained from the queued command structure,
> we can simplify the interface of ata_build_rw_tf() by passing directly
> the qc structure as argument.
>
> Furthermore, since ata_scsi_rw_xlat() is never used for internal
> commands, we can also remove the internal tag check for the NCQ case.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> ---
Reviewed-by: Niklas Cassel <niklas.cassel@wdc.com>
prev parent reply other threads:[~2022-08-31 11:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 22:38 [PATCH] ata: libata-core: Simplify ata_build_rw_tf() Damien Le Moal
2022-08-31 11:33 ` Niklas Cassel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yw9HABQ398eis3Mk@x1-carbon \
--to=niklas.cassel@wdc.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=linux-ide@vger.kernel.org \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox