Re: [PATCH V3] ata: ahci: simplify init function

[Niklas Cassel <Niklas.Cassel@wdc.com>]

On Mon, Mar 17, 2025 at 03:00:46PM +0100, Tomas Henzl wrote:
> Hi Damien,
> 
> the V3  patch applies to the for-6.15 branch with just an offset.
> Can you take it as it is or do you want me to resend?
> 
> Regards,
> Tomas

Please rebase and send a v4 with an improved commit log.

-Remove the double newlines.

-Use paragraphs (with an empty line between paragraphs).
 (There can be multiple sentences in one paragraph.)

-Improve the motivation. I.e. "removing a few lines" doesn't make sense,
 you are actually adding lines:
 1 file changed, 12 insertions(+), 11 deletions(-)

 You are however moving all the IRQ vector allocations into a single
 place/function, instead of having the allocations spread out over
 two separate call sites, so your refactoring does make sense, since
 it improves code readability.


Kind regards,
Niklas