From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 712621A08A8; Tue, 18 Mar 2025 08:02:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742284927; cv=none; b=SA7JkNkF227xR/PCvoKfruhuW9KTkCXlfujtp2oNasf4xHDkm+Ypsn76Ug1Ss38+Axm67e+RTE3WsvBBk+auPOjlr2QPalbom/6VdLhpQPy9hwkhDGaH3inwIQXyQ8f90wl5bxJQdBJHiCNscX4VuCGfTidyt+ebhovQUuHycxk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742284927; c=relaxed/simple; bh=yq8bTVzhnA3ZI7HrCjVP8FhWvMQwJUtYAE8vqqYL5s8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AA2REjFMSCSZHyXBNzscHZDD89T6XnZQOQEBkPsFGAZ6dFrDX5xao9fvoSZ0qT6dCggEMf2Jkz6ZiuzRQjlvP1KKXUI4ATfW7OpmknME8UTgUZhWQbXIVlHbgnNLHTgW580v7cV3vEsSusl0z2KjFXNI71aoH5B77mYKV0WBbNw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=R+mKSbJP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="R+mKSbJP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2714C4CEE9; Tue, 18 Mar 2025 08:02:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742284926; bh=yq8bTVzhnA3ZI7HrCjVP8FhWvMQwJUtYAE8vqqYL5s8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R+mKSbJPB1ss5Vs63lwldxaAmkFlVaZJV4zK0VejpURVqy/6jktuA+zGi7mz5/+Yc 88zv6gOpNwMFqygMkwsMfI88+YOXeN6VF1dU4kbLRB/Ggq+qvHaNgzZpXTDtngKR3B KHBadiYdfUZ/Gu+x/3wpx2k3sCmSDYCXZIMB5AyOBsmJL+hWxbZag+skIS3uAy87Fc qSKb+RibvKbUt2DSsyyna2/BMpvKv3Bdd7TxyAheVKnOR5hqTmioZiS5k7MEV6tClA B2wBrC5k6ijXqkcld++DJ5rguqbIiQecm+OEOI2hYK0Ezc2JS8DqYtednIIoz6SCP6 tvsT0OVLBgLvg== Date: Tue, 18 Mar 2025 09:02:01 +0100 From: Niklas Cassel To: Huacai Chen Cc: Damien Le Moal , linux-ide@vger.kernel.org, Huacai Chen , Xuerui Wang , Daniel Kral , linux-kernel@vger.kernel.org, Yuli Wang , Jie Fan , Erpeng Xu Subject: Re: [PATCH V3] ahci: Marvell 88SE9215 controllers prefer DMA for ATAPI Message-ID: References: <20250312134654.6699-1-chenhuacai@loongson.cn> Precedence: bulk X-Mailing-List: linux-ide@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hello Huacai, On Wed, Mar 12, 2025 at 04:47:55PM +0100, Niklas Cassel wrote: > On Wed, Mar 12, 2025 at 09:46:54PM +0800, Huacai Chen wrote: > > We use CD/DVD drives under Marvell 88SE9215 SATA controller on many > > Loongson-based machines. We found its PIO doesn't work well, and on the > > opposite its DMA seems work very well. We don't know the detail of the > > 88SE9215 SATA controller, but we have tested different CD/DVD drives > > and they all have problems under 88SE9215 (but they all work well under > > an Intel SATA controller). So we can define a new dedicated AHCI board > > id named board_ahci_yes_fbs_atapi_dma for 88SE9215, and for this id we > > set the AHCI_HFLAG_ATAPI_DMA_QUIRK and ATA_QUIRK_ATAPI_MOD16_DMA flags > > on the SATA controller to prefer ATAPI DMA. > > This is a wall of text. > > Could you please use paragraphs? (with an empty line between paragraphs). > > (There can be multiple sentences in one paragraph.) > > This is a good example: > > commit 6bdbb73dc8d99fbb77f5db79dbb6f108708090b4 > Author: Bibo Mao > Date: Sat Mar 8 13:52:04 2025 +0800 > > LoongArch: KVM: Fix GPA size issue about VM > > Physical address space is 48 bit on Loongson-3A5000 physical machine, > however it is 47 bit for VM on Loongson-3A5000 system. Size of physical > address space of VM is the same with the size of virtual user space (a > half) of physical machine. > > Variable cpu_vabits represents user address space, kernel address space > is not included (user space and kernel space are both a half of total). > Here cpu_vabits, rather than cpu_vabits - 1, is to represent the size of > guest physical address space. > > Also there is strict checking about page fault GPA address, inject error > if it is larger than maximum GPA address of VM. > > Cc: stable@vger.kernel.org > Signed-off-by: Bibo Mao > Signed-off-by: Huacai Chen > > > > Otherwise, this looks good to me. If you want this patch to be queued up for 6.15, please send a new version this week, because after this week, it will instead be queued up for 6.16. Kind regards, Niklas