From: Niklas Cassel <Niklas.Cassel@wdc.com>
To: Hannes Reinecke <hare@suse.de>
Cc: Damien Le Moal <dlemoal@kernel.org>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: Re: [PATCH 0/6] libata: remove references to 'old' error handler
Date: Mon, 5 Jun 2023 15:09:49 +0000 [thread overview]
Message-ID: <ZH36tAPa94aCROSi@x1-carbon> (raw)
In-Reply-To: <ZH3uZZ/Gqi6HqEwU@x1-carbon>
On Mon, Jun 05, 2023 at 02:43:46PM +0000, Niklas Cassel wrote:
(snip)
> I assume that the regression report is related to the review comment
> that I gave, i.e. that ata_dump_status() is now called unconditionally:
>
> %stddev %change %stddev
> pp.vprintk_emit._printk.ata_dump_status.ata_scsi_qc_complete.ata_qc_complete_multiple
> 0.00 +22.4 22.41 ± 8% perf-profile.calltrace.cycles-
Perhaps unconditionally is not exactly the right word here,
but since the regular case is that a QC does not have flag
ATA_QCFLAG_QUIET set, you probably understood what I meant :)
Kind regards,
Niklas
next prev parent reply other threads:[~2023-06-05 15:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 22:52 [PATCH 0/6] libata: remove references to 'old' error handler Hannes Reinecke
2023-05-10 22:52 ` [PATCH 1/6] ata: remove reference to non-existing error_handler() Hannes Reinecke
2023-05-15 7:01 ` Damien Le Moal
2023-05-15 10:09 ` Niklas Cassel
2023-05-23 2:25 ` kernel test robot
2023-05-10 22:52 ` [PATCH 2/6] ata,scsi: remove ata_sas_port_{start,stop} callbacks Hannes Reinecke
2023-05-10 22:52 ` [PATCH 3/6] ata,scsi: remove ata_sas_port_destroy() Hannes Reinecke
2023-05-10 22:52 ` [PATCH 4/6] ata: remove ata_sas_sync_probe() Hannes Reinecke
2023-05-10 22:52 ` [PATCH 5/6] ata: inline ata_port_probe() Hannes Reinecke
2023-05-10 22:52 ` [PATCH 6/6] ata,scsi: cleanup ata_port_probe() Hannes Reinecke
2023-05-22 0:46 ` [PATCH 0/6] libata: remove references to 'old' error handler Damien Le Moal
2023-05-22 6:46 ` Hannes Reinecke
2023-06-05 14:43 ` Niklas Cassel
2023-06-05 15:09 ` Niklas Cassel [this message]
2023-06-05 15:12 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZH36tAPa94aCROSi@x1-carbon \
--to=niklas.cassel@wdc.com \
--cc=dlemoal@kernel.org \
--cc=hare@suse.de \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox