From: andy.shevchenko@gmail.com
To: Nikita Shubin <nikita.shubin@maquefel.me>
Cc: Alexander Sverdlin <alexander.sverdlin@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Linus Walleij <linus.walleij@linaro.org>,
Sergey Shtylyov <s.shtylyov@omp.ru>,
Damien Le Moal <dlemoal@kernel.org>,
Michael Peters <mpeters@embeddedts.com>,
Kris Bahnsen <kris@embeddedts.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 26/43] pata: cirrus: add DT support for Cirrus EP93xx
Date: Fri, 2 Jun 2023 04:54:40 +0300 [thread overview]
Message-ID: <ZHlL4FJnrLjTCXGd@surfacebook> (raw)
In-Reply-To: <20230601054549.10843-8-nikita.shubin@maquefel.me>
Thu, Jun 01, 2023 at 08:45:31AM +0300, Nikita Shubin kirjoitti:
> - find register range from the device tree
> - get interrupts from device tree
...
> #include <linux/ata.h>
> #include <linux/libata.h>
> #include <linux/platform_device.h>
> +#include <linux/mod_devicetable.h>
In all patches, can you try to put a new header inclusions to be ordered (to
some extent)?
> #include <linux/delay.h>
> #include <linux/dmaengine.h>
> #include <linux/ktime.h>
With the context above a new one is logically suits this location.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-06-02 1:54 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 12:34 [PATCH 00/43] ep93xx device tree conversion Nikita Shubin
2023-04-24 11:31 ` Arnd Bergmann
[not found] ` <20230424152933.48b2ede1@kernel.org>
2023-04-25 9:20 ` Krzysztof Kozlowski
2023-04-25 13:27 ` Arnd Bergmann
2023-04-24 12:34 ` [PATCH 24/43] dt-bindings: ata: Add DT bindings ep93xx pata Nikita Shubin
2023-04-24 13:16 ` Damien Le Moal
2023-04-24 12:34 ` [PATCH 25/43] pata: cirrus: add DT support for Cirrus EP93xx Nikita Shubin
2023-04-26 20:56 ` [PATCH 00/43] ep93xx device tree conversion Linus Walleij
[not found] ` <b5396ef5-3fed-4e98-8f37-a9cd4473bddc@sirena.org.uk>
2023-04-26 21:06 ` Linus Walleij
2023-05-16 3:47 ` Florian Fainelli
2023-05-16 10:37 ` Nikita Shubin
2023-06-01 5:45 ` [PATCH v1 25/43] dt-bindings: ata: Add Cirrus EP93xx Nikita Shubin
2023-06-01 23:57 ` Damien Le Moal
2023-06-04 19:24 ` Nikita Shubin
2023-06-14 19:00 ` Rob Herring
2023-06-15 0:49 ` Damien Le Moal
2023-06-01 5:45 ` [PATCH v1 26/43] pata: cirrus: add DT support for " Nikita Shubin
2023-06-01 23:47 ` Damien Le Moal
2023-06-02 1:54 ` andy.shevchenko [this message]
2023-06-02 20:03 ` Sergey Shtylyov
2023-06-04 19:29 ` Nikita Shubin
2023-06-01 5:45 ` [PATCH v1 38/43] pata: cirrus: drop legacy pinctrl Nikita Shubin
2023-06-01 23:50 ` Damien Le Moal
2023-06-02 1:52 ` andy.shevchenko
2023-06-02 5:04 ` Damien Le Moal
2023-06-02 20:40 ` Sergey Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHlL4FJnrLjTCXGd@surfacebook \
--to=andy.shevchenko@gmail.com \
--cc=alexander.sverdlin@gmail.com \
--cc=arnd@arndb.de \
--cc=dlemoal@kernel.org \
--cc=kris@embeddedts.com \
--cc=linus.walleij@linaro.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpeters@embeddedts.com \
--cc=nikita.shubin@maquefel.me \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox