From: Niklas Cassel <Niklas.Cassel@wdc.com>
To: Pawel Zmarzly <pzmarzly@meta.com>
Cc: Damien Le Moal <dlemoal@kernel.org>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] ata: Disable NCQ_TRIM on Micron 1100 drives
Date: Fri, 1 Sep 2023 18:51:52 +0000 [thread overview]
Message-ID: <ZPIyxg+iSWa+W93Q@x1-carbon> (raw)
In-Reply-To: <20230901182317.3243660-1-pzmarzly@meta.com>
Hello Pawel,
On Fri, Sep 01, 2023 at 11:23:17AM -0700, Pawel Zmarzly wrote:
> Micron 1100 drives lock up when encountering queued TRIM command.
> It is a quite old hardware series, for past years we have been
> running our machines with these drives using
> libata.force=noncqtrim.
> ---
> V1 -> V2: Fixed formatting.
> ---
> drivers/ata/libata-core.c | 2 ++
> 1 file changed, 2 insertions(+)
I think you forgot your Signed-off-by tag this time.
See:
https://docs.kernel.org/process/submitting-patches.html#the-canonical-patch-format
E.g.
<commit message>
...
Signed-off-by: Author <author@mail>
---
V2 -> V3: Removed redundant helper function
V1 -> V2: Cleaned up coding style and addressed review comments
path/to/file | 5+++--
...
If you run ./scripts/checkpatch.pl against your patch,
it should tell you if the Signed-off-by tag is missing.
Kind regards,
Niklas
next prev parent reply other threads:[~2023-09-01 18:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 0:02 [PATCH] ata: Disable NCQ_TRIM on Micron 1100 drives Pawel Zmarzly
2023-09-01 9:49 ` Niklas Cassel
2023-09-01 18:23 ` [PATCH v2] " Pawel Zmarzly
2023-09-01 18:51 ` Niklas Cassel [this message]
2023-09-01 20:02 ` [PATCH v3] " Pawel Zmarzly
2023-09-01 20:19 ` Niklas Cassel
2023-09-02 2:54 ` Damien Le Moal
2023-09-02 3:11 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPIyxg+iSWa+W93Q@x1-carbon \
--to=niklas.cassel@wdc.com \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pzmarzly@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox