* [PATCH] ata: Disable NCQ_TRIM on Micron 1100 drives
@ 2023-08-31 0:02 Pawel Zmarzly
2023-09-01 9:49 ` Niklas Cassel
0 siblings, 1 reply; 8+ messages in thread
From: Pawel Zmarzly @ 2023-08-31 0:02 UTC (permalink / raw)
To: Damien Le Moal; +Cc: linux-ide, linux-kernel, Pawel Zmarzly
Micron 1100 drives lock up when encountering queued TRIM command.
It is a quite old hardware series, for past years we have been
running our machines with these drives using
libata.force=noncqtrim.
Signed-off-by: Pawel Zmarzly <pzmarzly@meta.com>
---
drivers/ata/libata-core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 175b2a9dc000..d2466f2c5fea 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4564,6 +4564,8 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
ATA_HORKAGE_ZERO_AFTER_TRIM, },
{ "FCCT*M500*", NULL, ATA_HORKAGE_NO_NCQ_TRIM |
ATA_HORKAGE_ZERO_AFTER_TRIM, },
+ { "Micron_1100_*", NULL, ATA_HORKAGE_NO_NCQ_TRIM |
+ ATA_HORKAGE_ZERO_AFTER_TRIM, },
/* devices that don't properly handle TRIM commands */
{ "SuperSSpeed S238*", NULL, ATA_HORKAGE_NOTRIM, },
--
2.39.3
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] ata: Disable NCQ_TRIM on Micron 1100 drives
2023-08-31 0:02 [PATCH] ata: Disable NCQ_TRIM on Micron 1100 drives Pawel Zmarzly
@ 2023-09-01 9:49 ` Niklas Cassel
2023-09-01 18:23 ` [PATCH v2] " Pawel Zmarzly
0 siblings, 1 reply; 8+ messages in thread
From: Niklas Cassel @ 2023-09-01 9:49 UTC (permalink / raw)
To: Pawel Zmarzly
Cc: Damien Le Moal, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
On Wed, Aug 30, 2023 at 05:02:22PM -0700, Pawel Zmarzly wrote:
Hello Pawel,
> Micron 1100 drives lock up when encountering queued TRIM command.
> It is a quite old hardware series, for past years we have been
> running our machines with these drives using
> libata.force=noncqtrim.
>
> Signed-off-by: Pawel Zmarzly <pzmarzly@meta.com>
> ---
> drivers/ata/libata-core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 175b2a9dc000..d2466f2c5fea 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4564,6 +4564,8 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
> ATA_HORKAGE_ZERO_AFTER_TRIM, },
> { "FCCT*M500*", NULL, ATA_HORKAGE_NO_NCQ_TRIM |
> ATA_HORKAGE_ZERO_AFTER_TRIM, },
> + { "Micron_1100_*", NULL, ATA_HORKAGE_NO_NCQ_TRIM |
> + ATA_HORKAGE_ZERO_AFTER_TRIM, },
Please align ATA_HORKAGE_ZERO_AFTER_TRIM to ATA_HORKAGE_NO_NCQ_TRIM,
instead of aligning it to NULL. (That way it matches the existing entries.)
Kind regards,
Niklas
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH v2] ata: Disable NCQ_TRIM on Micron 1100 drives
2023-09-01 9:49 ` Niklas Cassel
@ 2023-09-01 18:23 ` Pawel Zmarzly
2023-09-01 18:51 ` Niklas Cassel
0 siblings, 1 reply; 8+ messages in thread
From: Pawel Zmarzly @ 2023-09-01 18:23 UTC (permalink / raw)
To: Damien Le Moal, Niklas.Cassel; +Cc: linux-ide, linux-kernel, Pawel Zmarzly
Micron 1100 drives lock up when encountering queued TRIM command.
It is a quite old hardware series, for past years we have been
running our machines with these drives using
libata.force=noncqtrim.
---
V1 -> V2: Fixed formatting.
---
drivers/ata/libata-core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 175b2a9dc000..116f5fd6e3f7 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4564,6 +4564,8 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
ATA_HORKAGE_ZERO_AFTER_TRIM, },
{ "FCCT*M500*", NULL, ATA_HORKAGE_NO_NCQ_TRIM |
ATA_HORKAGE_ZERO_AFTER_TRIM, },
+ { "Micron_1100_*", NULL, ATA_HORKAGE_NO_NCQ_TRIM |
+ ATA_HORKAGE_ZERO_AFTER_TRIM, },
/* devices that don't properly handle TRIM commands */
{ "SuperSSpeed S238*", NULL, ATA_HORKAGE_NOTRIM, },
--
2.39.3
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v2] ata: Disable NCQ_TRIM on Micron 1100 drives
2023-09-01 18:23 ` [PATCH v2] " Pawel Zmarzly
@ 2023-09-01 18:51 ` Niklas Cassel
2023-09-01 20:02 ` [PATCH v3] " Pawel Zmarzly
0 siblings, 1 reply; 8+ messages in thread
From: Niklas Cassel @ 2023-09-01 18:51 UTC (permalink / raw)
To: Pawel Zmarzly
Cc: Damien Le Moal, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Hello Pawel,
On Fri, Sep 01, 2023 at 11:23:17AM -0700, Pawel Zmarzly wrote:
> Micron 1100 drives lock up when encountering queued TRIM command.
> It is a quite old hardware series, for past years we have been
> running our machines with these drives using
> libata.force=noncqtrim.
> ---
> V1 -> V2: Fixed formatting.
> ---
> drivers/ata/libata-core.c | 2 ++
> 1 file changed, 2 insertions(+)
I think you forgot your Signed-off-by tag this time.
See:
https://docs.kernel.org/process/submitting-patches.html#the-canonical-patch-format
E.g.
<commit message>
...
Signed-off-by: Author <author@mail>
---
V2 -> V3: Removed redundant helper function
V1 -> V2: Cleaned up coding style and addressed review comments
path/to/file | 5+++--
...
If you run ./scripts/checkpatch.pl against your patch,
it should tell you if the Signed-off-by tag is missing.
Kind regards,
Niklas
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v3] ata: Disable NCQ_TRIM on Micron 1100 drives
2023-09-01 18:51 ` Niklas Cassel
@ 2023-09-01 20:02 ` Pawel Zmarzly
2023-09-01 20:19 ` Niklas Cassel
2023-09-02 2:54 ` Damien Le Moal
0 siblings, 2 replies; 8+ messages in thread
From: Pawel Zmarzly @ 2023-09-01 20:02 UTC (permalink / raw)
To: Niklas.Cassel; +Cc: Damien Le Moal, linux-ide, linux-kernel, Pawel Zmarzly
Micron 1100 drives lock up when encountering queued TRIM command.
It is a quite old hardware series, for past years we have been
running our machines with these drives using
libata.force=noncqtrim.
Signed-off-by: Pawel Zmarzly <pzmarzly@meta.com>
---
V1 -> V2: Fixed formatting.
V2 -> V3: Added missing Signed off line. Sorry, this is my
first time upstreaming.
drivers/ata/libata-core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 175b2a9dc000..116f5fd6e3f7 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4564,6 +4564,8 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
ATA_HORKAGE_ZERO_AFTER_TRIM, },
{ "FCCT*M500*", NULL, ATA_HORKAGE_NO_NCQ_TRIM |
ATA_HORKAGE_ZERO_AFTER_TRIM, },
+ { "Micron_1100_*", NULL, ATA_HORKAGE_NO_NCQ_TRIM |
+ ATA_HORKAGE_ZERO_AFTER_TRIM, },
/* devices that don't properly handle TRIM commands */
{ "SuperSSpeed S238*", NULL, ATA_HORKAGE_NOTRIM, },
--
2.39.3
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v3] ata: Disable NCQ_TRIM on Micron 1100 drives
2023-09-01 20:02 ` [PATCH v3] " Pawel Zmarzly
@ 2023-09-01 20:19 ` Niklas Cassel
2023-09-02 2:54 ` Damien Le Moal
1 sibling, 0 replies; 8+ messages in thread
From: Niklas Cassel @ 2023-09-01 20:19 UTC (permalink / raw)
To: Pawel Zmarzly
Cc: Damien Le Moal, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
On Fri, Sep 01, 2023 at 01:02:21PM -0700, Pawel Zmarzly wrote:
> Micron 1100 drives lock up when encountering queued TRIM command.
> It is a quite old hardware series, for past years we have been
> running our machines with these drives using
> libata.force=noncqtrim.
>
> Signed-off-by: Pawel Zmarzly <pzmarzly@meta.com>
> ---
> V1 -> V2: Fixed formatting.
> V2 -> V3: Added missing Signed off line. Sorry, this is my
> first time upstreaming.
>
> drivers/ata/libata-core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 175b2a9dc000..116f5fd6e3f7 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4564,6 +4564,8 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
> ATA_HORKAGE_ZERO_AFTER_TRIM, },
> { "FCCT*M500*", NULL, ATA_HORKAGE_NO_NCQ_TRIM |
> ATA_HORKAGE_ZERO_AFTER_TRIM, },
> + { "Micron_1100_*", NULL, ATA_HORKAGE_NO_NCQ_TRIM |
> + ATA_HORKAGE_ZERO_AFTER_TRIM, },
>
> /* devices that don't properly handle TRIM commands */
> { "SuperSSpeed S238*", NULL, ATA_HORKAGE_NOTRIM, },
> --
> 2.39.3
Reviewed-by: Niklas Cassel <niklas.cassel@wdc.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v3] ata: Disable NCQ_TRIM on Micron 1100 drives
2023-09-01 20:02 ` [PATCH v3] " Pawel Zmarzly
2023-09-01 20:19 ` Niklas Cassel
@ 2023-09-02 2:54 ` Damien Le Moal
2023-09-02 3:11 ` Damien Le Moal
1 sibling, 1 reply; 8+ messages in thread
From: Damien Le Moal @ 2023-09-02 2:54 UTC (permalink / raw)
To: Pawel Zmarzly, Niklas.Cassel; +Cc: linux-ide, linux-kernel
On 9/2/23 05:02, Pawel Zmarzly wrote:
> Micron 1100 drives lock up when encountering queued TRIM command.
> It is a quite old hardware series, for past years we have been
> running our machines with these drives using
> libata.force=noncqtrim.
>
> Signed-off-by: Pawel Zmarzly <pzmarzly@meta.com>
This does not apply cleanly on the fo-6.6 branch. Can you rebase your patch
please and make sure it applies to libata tree for-6.6 branch ?
> ---
> V1 -> V2: Fixed formatting.
> V2 -> V3: Added missing Signed off line. Sorry, this is my
> first time upstreaming.
>
> drivers/ata/libata-core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 175b2a9dc000..116f5fd6e3f7 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4564,6 +4564,8 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
> ATA_HORKAGE_ZERO_AFTER_TRIM, },
> { "FCCT*M500*", NULL, ATA_HORKAGE_NO_NCQ_TRIM |
> ATA_HORKAGE_ZERO_AFTER_TRIM, },
> + { "Micron_1100_*", NULL, ATA_HORKAGE_NO_NCQ_TRIM |
> + ATA_HORKAGE_ZERO_AFTER_TRIM, },
>
> /* devices that don't properly handle TRIM commands */
> { "SuperSSpeed S238*", NULL, ATA_HORKAGE_NOTRIM, },
> --
> 2.39.3
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v3] ata: Disable NCQ_TRIM on Micron 1100 drives
2023-09-02 2:54 ` Damien Le Moal
@ 2023-09-02 3:11 ` Damien Le Moal
0 siblings, 0 replies; 8+ messages in thread
From: Damien Le Moal @ 2023-09-02 3:11 UTC (permalink / raw)
To: Pawel Zmarzly, Niklas.Cassel; +Cc: linux-ide, linux-kernel
On 9/2/23 11:54, Damien Le Moal wrote:
> On 9/2/23 05:02, Pawel Zmarzly wrote:
>> Micron 1100 drives lock up when encountering queued TRIM command.
>> It is a quite old hardware series, for past years we have been
>> running our machines with these drives using
>> libata.force=noncqtrim.
>>
>> Signed-off-by: Pawel Zmarzly <pzmarzly@meta.com>
>
> This does not apply cleanly on the fo-6.6 branch. Can you rebase your patch
> please and make sure it applies to libata tree for-6.6 branch ?
Don't bother. I applied the patch manually with some minor tweaks.
It is now queued for 6.6. Thanks.
>
>> ---
>> V1 -> V2: Fixed formatting.
>> V2 -> V3: Added missing Signed off line. Sorry, this is my
>> first time upstreaming.
>>
>> drivers/ata/libata-core.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
>> index 175b2a9dc000..116f5fd6e3f7 100644
>> --- a/drivers/ata/libata-core.c
>> +++ b/drivers/ata/libata-core.c
>> @@ -4564,6 +4564,8 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
>> ATA_HORKAGE_ZERO_AFTER_TRIM, },
>> { "FCCT*M500*", NULL, ATA_HORKAGE_NO_NCQ_TRIM |
>> ATA_HORKAGE_ZERO_AFTER_TRIM, },
>> + { "Micron_1100_*", NULL, ATA_HORKAGE_NO_NCQ_TRIM |
>> + ATA_HORKAGE_ZERO_AFTER_TRIM, },
>>
>> /* devices that don't properly handle TRIM commands */
>> { "SuperSSpeed S238*", NULL, ATA_HORKAGE_NOTRIM, },
>> --
>> 2.39.3
>
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-09-02 3:11 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-31 0:02 [PATCH] ata: Disable NCQ_TRIM on Micron 1100 drives Pawel Zmarzly
2023-09-01 9:49 ` Niklas Cassel
2023-09-01 18:23 ` [PATCH v2] " Pawel Zmarzly
2023-09-01 18:51 ` Niklas Cassel
2023-09-01 20:02 ` [PATCH v3] " Pawel Zmarzly
2023-09-01 20:19 ` Niklas Cassel
2023-09-02 2:54 ` Damien Le Moal
2023-09-02 3:11 ` Damien Le Moal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox