From: andy.shevchenko@gmail.com
To: Nikita Shubin <nikita.shubin@maquefel.me>
Cc: Sergey Shtylyov <s.shtylyov@omp.ru>,
Damien Le Moal <dlemoal@kernel.org>,
Niklas Cassel <cassel@kernel.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v7 22/39] ata: pata_ep93xx: add device tree support
Date: Sun, 4 Feb 2024 19:00:52 +0200 [thread overview]
Message-ID: <Zb_CxFpxm3WoyeCC@surfacebook.localdomain> (raw)
In-Reply-To: <20240118-ep93xx-v7-22-d953846ae771@maquefel.me>
Thu, Jan 18, 2024 at 11:21:05AM +0300, Nikita Shubin kirjoitti:
> - add OF ID match table
> - drop platform DMA and filters
> - change DMA setup to OF, so we can defer probe
...
> + drv_data->dma_rx_channel = dma_request_chan(dev, "rx");
> + if (IS_ERR(drv_data->dma_rx_channel)) {
> + ret = PTR_ERR(drv_data->dma_rx_channel);
> + return dev_err_probe(dev, ret, "rx DMA setup failed\n");
It can be done in one statement:
return dev_err_probe(dev, PTR_ERR(drv_data->dma_rx_channel),
"rx DMA setup failed\n");
> + }
...
> + drv_data->dma_tx_channel = dma_request_chan(&pdev->dev, "tx");
> + if (IS_ERR(drv_data->dma_tx_channel)) {
> + ret = PTR_ERR(drv_data->dma_tx_channel);
> + dev_err_probe(dev, ret, "tx DMA setup failed\n");
In the similar way
ret = dev_err_probe(...);
> + goto fail_release_rx;
> }
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-02-04 17:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 8:20 [PATCH v7 00/39] ep93xx device tree conversion Nikita Shubin via B4 Relay
2024-01-18 8:21 ` [PATCH v7 21/39] dt-bindings: ata: Add Cirrus EP93xx Nikita Shubin via B4 Relay
2024-01-18 8:21 ` [PATCH v7 22/39] ata: pata_ep93xx: add device tree support Nikita Shubin via B4 Relay
2024-02-04 17:00 ` andy.shevchenko [this message]
2024-01-18 8:21 ` [PATCH v7 35/39] ata: pata_ep93xx: remove legacy pinctrl use Nikita Shubin via B4 Relay
2024-01-18 9:30 ` [PATCH v7 00/39] ep93xx device tree conversion Uwe Kleine-König
2024-01-18 9:36 ` Nikita Shubin
2024-02-04 17:03 ` andy.shevchenko
2024-02-13 9:48 ` Nikita Shubin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zb_CxFpxm3WoyeCC@surfacebook.localdomain \
--to=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikita.shubin@maquefel.me \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox